diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2018-12-18 10:24:55 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-01-07 10:27:32 +0000 |
| commit | f212cf3506a9ad3d699a4afe148bfd554932f7b8 (patch) | |
| tree | 86f810f53d78c9f1e368f4e75d3991158cec2fcf /src/soc/intel/fsp_broadwell_de | |
| parent | 844eda0f3b69e8b724fdf14fc663f808f686037f (diff) | |
soc/intel: Standardize names of common MSRs
Use defined name in Intel 64 and IA-32 Architectures Software
Developer’s Manual.
Renamed MSRs are (register address, register name):
0x35 MSR_CORE_THREAD_COUNT
0x121 MSR_EMULATE_PM_TIMER
0x1f4 MSR_PRMRR_PHYS_BASE
0x1f5 MSR_PRMRR_PHYS_MASK
0x2f4 MSR_UNCORE_PRMRR_PHYS_BASE
0x2f5 MSR_UNCORE_PRMRR_PHYS_MASK
Change-Id: I53f11a2ce831456d598aa21303a817d18ac89bba
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/30288
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Diffstat (limited to 'src/soc/intel/fsp_broadwell_de')
| -rw-r--r-- | src/soc/intel/fsp_broadwell_de/include/soc/msr.h | 4 | ||||
| -rw-r--r-- | src/soc/intel/fsp_broadwell_de/smmrelocate.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/intel/fsp_broadwell_de/include/soc/msr.h b/src/soc/intel/fsp_broadwell_de/include/soc/msr.h index ed42fdf4cf..e4b8c50e20 100644 --- a/src/soc/intel/fsp_broadwell_de/include/soc/msr.h +++ b/src/soc/intel/fsp_broadwell_de/include/soc/msr.h @@ -35,7 +35,7 @@ /* MTRR_CAP_MSR bits */ #define SMRR_SUPPORTED (1 << 11) #define PRMRR_SUPPORTED (1 << 12) -#define PRMRRphysBase_MSR 0x1f4 -#define PRMRRphysMask_MSR 0x1f5 +#define MSR_PRMRR_PHYS_BASE 0x1f4 +#define MSR_PRMRR_PHYS_MASK 0x1f5 #endif /* _SOC_MSR_H_ */ diff --git a/src/soc/intel/fsp_broadwell_de/smmrelocate.c b/src/soc/intel/fsp_broadwell_de/smmrelocate.c index c8a9e004f1..f8f98c231d 100644 --- a/src/soc/intel/fsp_broadwell_de/smmrelocate.c +++ b/src/soc/intel/fsp_broadwell_de/smmrelocate.c @@ -46,8 +46,8 @@ static inline void write_prmrr(struct smm_relocation_params *relo_params) { printk(BIOS_DEBUG, "Writing PRMRR. base = 0x%08x, mask=0x%08x\n", relo_params->prmrr_base.lo, relo_params->prmrr_mask.lo); - wrmsr(PRMRRphysBase_MSR, relo_params->prmrr_base); - wrmsr(PRMRRphysMask_MSR, relo_params->prmrr_mask); + wrmsr(MSR_PRMRR_PHYS_BASE, relo_params->prmrr_base); + wrmsr(MSR_PRMRR_PHYS_MASK, relo_params->prmrr_mask); } static void update_save_state(int cpu, uintptr_t curr_smbase, |