diff options
author | Elyes Haouas <ehaouas@noos.fr> | 2024-03-23 15:40:00 +0100 |
---|---|---|
committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-03-30 08:29:38 +0000 |
commit | c0d3cf105254c0bbde5c57c8817f5263271fb0fe (patch) | |
tree | b76d060dcb00f6696ded9e39bdc7a7808bcb1e72 /src/soc/intel/common/block | |
parent | 57351dd872746392175f5684b04ac9fb0a5d5538 (diff) |
soc/intel: Remove blank lines before '}' and after '{'
Change-Id: I79b93b0ca446411e2a1feb65d00045e3be85ee8a
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81489
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'src/soc/intel/common/block')
-rw-r--r-- | src/soc/intel/common/block/acpi/acpi.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/acpi/acpi_bert.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/cpu/cpulib.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/crashlog/crashlog.c | 5 | ||||
-rw-r--r-- | src/soc/intel/common/block/cse/cse.c | 2 | ||||
-rw-r--r-- | src/soc/intel/common/block/cse/cse_lite.c | 2 | ||||
-rw-r--r-- | src/soc/intel/common/block/cse/telemetry.c | 2 | ||||
-rw-r--r-- | src/soc/intel/common/block/fast_spi/mmap_boot.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/gpio/gpio.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/sgx/sgx.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/tcss/tcss.c | 2 |
11 files changed, 0 insertions, 19 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index cd60416c44..1faf433113 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -273,7 +273,6 @@ void generate_p_state_entries(int core, int cores_per_package) /* Generate the remaining entries */ for (ratio = ratio_min + ((num_entries - 1) * ratio_step); ratio >= ratio_min; ratio -= ratio_step) { - /* Calculate power at this ratio */ power = common_calculate_power_ratio(power_max, ratio_max, ratio); clock = (ratio * cpu_get_bus_clock()) / KHz; diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c index 417dad3ac7..8c1bd34a02 100644 --- a/src/soc/intel/common/block/acpi/acpi_bert.c +++ b/src/soc/intel/common/block/acpi/acpi_bert.c @@ -54,7 +54,6 @@ static enum cb_err record_crashlog_into_bert(void **region, size_t *length) bool multi_entry = false; cl_node_t *cl_node = cl_list_head.next; while (cl_node) { - if ((cl_node->size <= 0) || (!(cl_node->data))) { cl_node = cl_node->next; continue; diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index 1cefc1277e..0a9de869ff 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -154,7 +154,6 @@ void cpu_set_p_state_to_min_clock_ratio(void) */ int cpu_get_burst_mode_state(void) { - msr_t msr; unsigned int eax; int burst_en, burst_cap, burst_state = BURST_MODE_UNKNOWN; diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 6735d971ba..541dea4482 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -200,7 +200,6 @@ bool __weak cpu_cl_discovery(void) int cl_pmc_re_arm_after_reset(void) { - const struct pmc_ipc_buffer req = { 0 }; struct pmc_ipc_buffer res; uint32_t cmd_reg; @@ -400,7 +399,6 @@ void __weak cl_get_pmc_sram_data(cl_node_t *head) if (discovery_buf.bits.discov_mechanism == 1) { for (int i = 0; i < descriptor_table.numb_regions; i++) { - cl_node_t *cl_node = malloc_cl_node(descriptor_table.regions[i].bits.size); if (!cl_node) { printk(BIOS_DEBUG, "failed to allocate cl_node [region = %d]\n", i); @@ -425,7 +423,6 @@ void __weak cl_get_pmc_sram_data(cl_node_t *head) } } } else { - cl_node_t *cl_node = malloc_cl_node(discovery_buf.bits.size); if (!cl_node) { printk(BIOS_DEBUG, "failed to allocate cl_node\n"); @@ -458,7 +455,6 @@ pmc_send_re_arm_after_reset: /* Clear the SSRAM region after copying the error log */ cl_pmc_clear(); - } void cl_get_cpu_sram_data(cl_node_t *head) @@ -481,7 +477,6 @@ void cl_get_cpu_sram_data(cl_node_t *head) } for (int i = 0 ; i < cpu_cl_disc_tab.header.fields.count ; i++) { - u32 cpu_bar_addr = cl_get_cpu_bar_addr(); bool pmc_sram = false; diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 6d7569dbb0..d0ca57bc05 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -1258,7 +1258,6 @@ static void me_reset_with_count(void) */ printk(BIOS_ERR, "Failed to change ME state in %u attempts!\n", ME_DISABLE_ATTEMPTS); - } } else { printk(BIOS_DEBUG, "ME: Resetting"); @@ -1268,7 +1267,6 @@ static void me_reset_with_count(void) static void cse_set_state(struct device *dev) { - /* (CS)ME Disable Command */ struct me_disable_command { struct mkhi_hdr hdr; diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 5298b315d7..3579bcea78 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -83,7 +83,6 @@ enum bp_status { * The flags are returned in response to MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO cmd. */ enum bp_info_flags { - /* Redundancy Enabled: It indicates CSE supports RO(BP1) and RW(BP2) regions */ BP_INFO_REDUNDANCY_EN = 1 << 0, @@ -715,7 +714,6 @@ static void cse_get_bp_entry_range(enum boot_partition_id bp, uint32_t *start_of if (end_offset) *end_offset = cse_bp->end_offset; - } static bool cse_is_rw_bp_status_valid(void) diff --git a/src/soc/intel/common/block/cse/telemetry.c b/src/soc/intel/common/block/cse/telemetry.c index 6502be99c9..c1c70e5595 100644 --- a/src/soc/intel/common/block/cse/telemetry.c +++ b/src/soc/intel/common/block/cse/telemetry.c @@ -28,7 +28,6 @@ static void process_cse_telemetry_data(void) current_time = timestamp_get(); for (unsigned int i = 0; i < NUM_CSE_BOOT_PERF_DATA; i++) { - if (cse_perf_data.timestamp[i] == 0xffffffff) { printk(BIOS_ERR, "%s: CSME timestamps invalid\n", __func__); return; @@ -48,7 +47,6 @@ static void process_cse_telemetry_data(void) /* Normalize TS values to zero-point */ for (unsigned int i = zero_point_idx + 1; i < NUM_CSE_BOOT_PERF_DATA; i++) { - if (ts[i] && ts[i] < ts[zero_point_idx]) { printk(BIOS_ERR, "%s: CSME timestamps invalid," " wraparound detected\n", __func__); diff --git a/src/soc/intel/common/block/fast_spi/mmap_boot.c b/src/soc/intel/common/block/fast_spi/mmap_boot.c index fa163d7e49..bc31edc24f 100644 --- a/src/soc/intel/common/block/fast_spi/mmap_boot.c +++ b/src/soc/intel/common/block/fast_spi/mmap_boot.c @@ -170,7 +170,6 @@ uint32_t spi_flash_get_mmap_windows(struct flash_mmap_window *table) bios_mmap_init(); for (i = 0; i < TOTAL_DECODE_WINDOWS; i++) { - if (region_sz(&real_dev_windows[i].sub_region) == 0) continue; diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c index 09ada90ccc..63d7a5e8d2 100644 --- a/src/soc/intel/common/block/gpio/gpio.c +++ b/src/soc/intel/common/block/gpio/gpio.c @@ -810,7 +810,6 @@ void gpi_clear_get_smi_status(struct gpi_status *sts) if (CONFIG(DEBUG_SMI)) print_gpi_status(sts); - } int gpi_status_get(const struct gpi_status *sts, gpio_t pad) diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c index 31447f9a76..9f30b92846 100644 --- a/src/soc/intel/common/block/sgx/sgx.c +++ b/src/soc/intel/common/block/sgx/sgx.c @@ -163,7 +163,6 @@ static int is_prmrr_approved(void) */ void sgx_configure(void *unused) { - if (!is_sgx_supported() || !is_prmrr_set()) { printk(BIOS_ERR, "SGX: not supported or pre-conditions not met\n"); return; diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 8080c25fce..1c4b9b391f 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -41,7 +41,6 @@ static uint32_t tcss_make_alt_mode_cmd_buf_0(int u, int u3, int m) return TCSS_ALT_FIELD(USAGE, u) | TCSS_ALT_FIELD(USB3, u3) | TCSS_ALT_FIELD(MODE, m); - } static uint32_t tcss_make_alt_mode_cmd_buf_1(int p, int c, int ufp, int dp) @@ -65,7 +64,6 @@ static uint32_t tcss_make_hpd_mode_cmd(int u, int u3, int hpd_lvl, int hpd_irq) TCSS_HPD_FIELD(USB3, u3) | TCSS_HPD_FIELD(LVL, hpd_lvl) | TCSS_HPD_FIELD(IRQ, hpd_irq); - } static int send_pmc_req(int cmd_type, const struct pmc_ipc_buffer *req, |