summaryrefslogtreecommitdiff
path: root/src/soc/intel/common/block
diff options
context:
space:
mode:
authorNicholas Sudsgaard <devel+coreboot@nsudsgaard.com>2024-01-30 09:53:46 +0900
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2024-01-31 09:51:58 +0000
commitbfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch)
tree0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/soc/intel/common/block
parentf4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff)
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/intel/common/block')
-rw-r--r--src/soc/intel/common/block/pcie/rtd3/rtd3.c2
-rw-r--r--src/soc/intel/common/block/uart/uart.c2
-rw-r--r--src/soc/intel/common/block/usb4/pcie.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/common/block/pcie/rtd3/rtd3.c b/src/soc/intel/common/block/pcie/rtd3/rtd3.c
index abd7e46671..39c82b11f2 100644
--- a/src/soc/intel/common/block/pcie/rtd3/rtd3.c
+++ b/src/soc/intel/common/block/pcie/rtd3/rtd3.c
@@ -567,6 +567,6 @@ static void pcie_rtd3_acpi_enable(struct device *dev)
}
struct chip_operations soc_intel_common_block_pcie_rtd3_ops = {
- CHIP_NAME("Intel PCIe Runtime D3")
+ .name = "Intel PCIe Runtime D3",
.enable_dev = pcie_rtd3_acpi_enable
};
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index 533fbee832..c03f5a9d36 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -433,7 +433,7 @@ static void uart_enable(struct device *dev)
}
struct chip_operations soc_intel_common_block_uart_ops = {
- CHIP_NAME("LPSS UART in ACPI mode")
+ .name = "LPSS UART in ACPI mode",
.enable_dev = uart_enable
};
diff --git a/src/soc/intel/common/block/usb4/pcie.c b/src/soc/intel/common/block/usb4/pcie.c
index 0139647949..f2414ccb12 100644
--- a/src/soc/intel/common/block/usb4/pcie.c
+++ b/src/soc/intel/common/block/usb4/pcie.c
@@ -81,6 +81,6 @@ static void usb4_pcie_acpi_enable(struct device *dev)
}
struct chip_operations soc_intel_common_block_usb4_ops = {
- CHIP_NAME("Intel USB4 PCIe Root Port")
+ .name = "Intel USB4 PCIe Root Port",
.enable_dev = usb4_pcie_acpi_enable
};