summaryrefslogtreecommitdiff
path: root/src/soc/intel/common/block/systemagent
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-05-11 19:14:58 -0700
committerAaron Durbin <adurbin@chromium.org>2020-05-14 15:06:28 +0000
commitabd4714ee059b075be5cb94d332602a4ce454bc9 (patch)
tree25b2786f308040929ae3faead6c16b247e30d0df /src/soc/intel/common/block/systemagent
parent1085fee761b381bbc2f9d18fb9cdc8a9e1c90884 (diff)
soc/intel: Always advertise MMIO window above 4G in ACPI tables
There should be no harm in advertising the MMIO window above 4G in ACPI tables unconditionally. OS can decide whether or not to use the window. This change removes the config option enable_above_4GB_mmio and instead adds the correct MMIO window (above 4G) details to ACPI tables always. Change-Id: Ie728f6ee7f396918e61b29ade862b57dac36cb08 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41276 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/common/block/systemagent')
-rw-r--r--src/soc/intel/common/block/systemagent/systemagent.c19
1 files changed, 0 insertions, 19 deletions
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c
index 3da837c0af..7355817ec2 100644
--- a/src/soc/intel/common/block/systemagent/systemagent.c
+++ b/src/soc/intel/common/block/systemagent/systemagent.c
@@ -96,30 +96,11 @@ static void sa_read_map_entry(struct device *dev,
*result = value;
}
-/*
- * This function will get above 4GB mmio enable config specific to soc.
- *
- * Return values:
- * 0 = Above 4GB memory is not enable
- * 1 = Above 4GB memory is enable
- */
-static int get_enable_above_4GB_mmio(void)
-{
- const struct soc_intel_common_config *common_config;
- common_config = chip_get_common_soc_structure();
-
- return common_config->enable_above_4GB_mmio;
-}
-
/* Fill MMIO resource above 4GB into GNVS */
void sa_fill_gnvs(global_nvs_t *gnvs)
{
- if (!get_enable_above_4GB_mmio())
- return;
-
struct device *sa_dev = pcidev_path_on_root(SA_DEVFN_ROOT);
- gnvs->e4gm = 1;
sa_read_map_entry(sa_dev, &sa_memory_map[SA_TOUUD_REG], &gnvs->a4gb);
gnvs->a4gs = ABOVE_4GB_MEM_BASE_SIZE;
printk(BIOS_DEBUG, "PCI space above 4GB MMIO is from 0x%llx to len = 0x%llx\n",