diff options
author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2019-09-18 11:22:56 -0600 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-09-20 07:16:44 +0000 |
commit | 954111695cb7e27647ed9c150cac2f77d39c1e09 (patch) | |
tree | dac2711d908f9c95ba5aa87c6ce1cce2de388c36 /src/soc/intel/common/block/include/intelblocks/imc.h | |
parent | 7f7ab8f16cd6524d0d0fd29141decdc32bc14182 (diff) |
mb/google/hatch: Remove GPIO_DRIVER from pen eject GPIO configuration
A closer read of the EDS indicates that when GPIO Driver mode is
selected, GPIO input event updates are limited to GPI_STS only.
GPI_GPE_STS updates are therefore masked, and we don't want to enable
this behavior. It masks the GPE and does not allow us to see this GPE
as a wake source, obscuring the reason that the system woke up.
Also switch the IRQ from level-triggered to edge-triggered,
otherwise the system will auto-wake from any sleep state when the
pen is ejected from the garage.
BUG=b:132981083
BRANCH=none
TEST=Wake up system from S0ix using pen eject, verify that mosys
eventlog shows GPE#8 as the S0ix wakeup source. Wake up system from S3
via pen eject, and verify that the wakeup source shows as GPE#8.
Change-Id: If017e12e23134f5cfed7cbb6047cc9badd9bf7e8
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35459
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/common/block/include/intelblocks/imc.h')
0 files changed, 0 insertions, 0 deletions