diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/soc/intel/common/block/acpi | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/soc/intel/common/block/acpi')
| -rw-r--r-- | src/soc/intel/common/block/acpi/acpi_bert.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c index 85fbc03f6e..beb131ee1b 100644 --- a/src/soc/intel/common/block/acpi/acpi_bert.c +++ b/src/soc/intel/common/block/acpi/acpi_bert.c @@ -39,7 +39,7 @@ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length) } if (!cl_get_total_data_size()) { - printk(BIOS_ERR, "Error: No crashlog record present\n"); + printk(BIOS_ERR, "No crashlog record present\n"); return CB_ERR; } @@ -47,12 +47,12 @@ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length) gesb_header_size = sizeof(*status); if (!status) { - printk(BIOS_ERR, "Error: unable to allocate GSB\n"); + printk(BIOS_ERR, "unable to allocate GSB\n"); return CB_ERR; } if (cl_get_total_data_size() > bert_storage_remaining()) { - printk(BIOS_ERR, "Error: Crashlog entry would exceed " + printk(BIOS_ERR, "Crashlog entry would exceed " "available region\n"); return CB_ERR; } @@ -61,7 +61,7 @@ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length) if (cpu_record_size) { cl_data = new_cper_fw_error_crashlog(status, cpu_record_size); if (!cl_data) { - printk(BIOS_ERR, "Error: Crashlog CPU entry(size %lu) " + printk(BIOS_ERR, "Crashlog CPU entry(size %lu) " "would exceed available region\n", cpu_record_size); return CB_ERR; @@ -75,14 +75,14 @@ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length) if (pmc_record_size) { /* Allocate new FW ERR structure in case CPU crashlog is present */ if (cpu_record_size && !bert_append_fw_err(status)) { - printk(BIOS_ERR, "Error: Crashlog PMC entry would " + printk(BIOS_ERR, "Crashlog PMC entry would " "exceed available region\n"); return CB_ERR; } cl_data = new_cper_fw_error_crashlog(status, pmc_record_size); if (!cl_data) { - printk(BIOS_ERR, "Error: Crashlog PMC entry(size %lu) " + printk(BIOS_ERR, "Crashlog PMC entry(size %lu) " "would exceed available region\n", pmc_record_size); return CB_ERR; |