summaryrefslogtreecommitdiff
path: root/src/soc/intel/common/block/acpi
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-07 22:39:53 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-11 19:57:58 +0000
commit9ac1fb729fa316564992403580254b1c4afbf9c2 (patch)
tree46475a185bea3b97586713927d1b78664cc2d6e5 /src/soc/intel/common/block/acpi
parent899c713e3eb073491d8b954165919daa87609493 (diff)
ACPI: Add helper for MADT LAPIC NMIs
This avoids some code duplication related to X2APIC mode. Change-Id: I2cb8676efc1aba1b154fd04c49e53b2530239b4c Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74311 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com>
Diffstat (limited to 'src/soc/intel/common/block/acpi')
-rw-r--r--src/soc/intel/common/block/acpi/cpu_hybrid.c13
1 files changed, 1 insertions, 12 deletions
diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c
index 7725e3fa0a..2e39f720ab 100644
--- a/src/soc/intel/common/block/acpi/cpu_hybrid.c
+++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c
@@ -95,19 +95,8 @@ static unsigned long acpi_create_madt_lapics_hybrid(unsigned long current)
unsigned long acpi_create_madt_lapics_with_nmis_hybrid(unsigned long current)
{
- const u16 flags = MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH;
-
current = acpi_create_madt_lapics_hybrid(current);
-
- /* 1: LINT1 connect to NMI */
- /* create all subtables for processors */
- current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current,
- ACPI_MADT_LAPIC_NMI_ALL_PROCESSORS, flags, 1);
-
- if (!CONFIG(XAPIC_ONLY))
- current += acpi_create_madt_lx2apic_nmi((acpi_madt_lx2apic_nmi_t *)current,
- ACPI_MADT_LX2APIC_NMI_ALL_PROCESSORS, flags, 1);
-
+ current = acpi_create_madt_lapic_nmis(current);
return current;
}