diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-02-19 16:08:36 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-03 09:07:59 +0000 |
| commit | d3a65deb255be26bdfbdae3b4b3625e4e3183a13 (patch) | |
| tree | 1ed21c0c462fdd733ab6ffdcc52fedb086581dcb /src/soc/intel/apollolake | |
| parent | b0f52fb5bfa71d2ddf5741408cc14fcfdf8f5ffc (diff) | |
soc/intel: Guard macro parameters in pm.h
Guard against unintended operator precedence and associativity issues.
Change-Id: I342682a57fde9942cdf7be10756ee21c10af802a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50917
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/apollolake')
| -rw-r--r-- | src/soc/intel/apollolake/include/soc/pm.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/apollolake/include/soc/pm.h b/src/soc/intel/apollolake/include/soc/pm.h index 748f76adba..b40a12fce3 100644 --- a/src/soc/intel/apollolake/include/soc/pm.h +++ b/src/soc/intel/apollolake/include/soc/pm.h @@ -120,7 +120,7 @@ #define GPE0_REG_MAX 4 #define GPE0_REG_SIZE 32 -#define GPE0_STS(x) (0x20 + (x * 4)) +#define GPE0_STS(x) (0x20 + ((x) * 4)) #define GPE0_A 0 #define GPE0_B 1 #define GPE0_C 2 @@ -136,7 +136,7 @@ #define BATLOW_STS (1 << 10) #define PCIE_GPE_STS (1 << 9) #define SWGPE_STS (1 << 2) -#define GPE0_EN(x) (0x30 + (x * 4)) +#define GPE0_EN(x) (0x30 + ((x) * 4)) #define ESPI_EN (1 << 20) /* This bit is present in GLK */ #define SATA_PME_EN (1 << 17) #define SMB_WAK_EN (1 << 16) |