summaryrefslogtreecommitdiff
path: root/src/soc/amd
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2023-05-17 17:36:19 -0600
committerFelix Held <felix-coreboot@felixheld.de>2023-05-22 12:45:30 +0000
commit2049bb9b2c04738388ae97b6ed6e84e1be84ae21 (patch)
tree14ff3cf61e6e7279283ab50c335c72ad703579be /src/soc/amd
parent4d002f356e0f00e88bf225ca6ea2453955e5093d (diff)
soc/amd/common/psp_verstage: Always build unsigned PSP verstage
Currently unsigned PSP verstage binary is copied from ELF file only when required in amdfw*.rom. If a signed PSP verstage binary is supplied while building amdfw*.rom, then it is dropped. Copy the unsigned PSP verstage binary always so that it can be used for signing directly from the CI build infrastructure instead of a locally built binary. BUG=None TEST=Build Skyrim BIOS image and ensure that the unsigned PSP verstage is part of the build artifacts. Change-Id: If797dcfd20aa2991f3517904ef862406b9b9875c Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75334 Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd')
-rw-r--r--src/soc/amd/common/psp_verstage/Makefile.inc7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/soc/amd/common/psp_verstage/Makefile.inc b/src/soc/amd/common/psp_verstage/Makefile.inc
index 54e1d0a37f..ee71d9930e 100644
--- a/src/soc/amd/common/psp_verstage/Makefile.inc
+++ b/src/soc/amd/common/psp_verstage/Makefile.inc
@@ -25,3 +25,10 @@ verstage-y += vboot_crypto.c
$(obj)/psp_verstage.bin: $(objcbfs)/verstage.elf
$(OBJCOPY_verstage) -O binary $^ $@
+
+# Default CONFIG_PSP_VERSTAGE_FILE configuration requires psp_verstage.bin and the above
+# build rule takes effect. Once CONFIG_PSP_VERSTAGE_FILE is overridden with signed PSP
+# verstage, then psp_verstage.bin is not built. The following build rule ensures that the
+# unsigned psp_verstage.bin is still built even when not used so that it can be used for
+# signing purposes.
+build_complete:: $(obj)/psp_verstage.bin