summaryrefslogtreecommitdiff
path: root/src/soc/amd/stoneyridge/Makefile.inc
diff options
context:
space:
mode:
authorZheng Bao <fishbaozi@gmail.com>2023-02-11 22:13:36 +0800
committerFelix Held <felix-coreboot@felixheld.de>2023-02-14 18:24:08 +0000
commit4bfb36ed68154d8ee6fc77a6b2bf79938cae9e8a (patch)
tree17d6a1dc6900148d3f5a8bcdd32a43619e1d390a /src/soc/amd/stoneyridge/Makefile.inc
parentaf69de494e2c32140ce5e00a1562c2845345b1bf (diff)
amdfwtool: use SoC ID info instead of misleading comboable flag
Since it actually depends on the SoC type whether the old PSP directory table pointer or the new comboable PSP directory table pointer is used in EFS, get this information from the SoC ID instead of passing the comboable flag for the SoCs that need to use the new comboable PSP directory table pointer. TEST=Binary identical on amd/majolica, pcengines/apu2, amd/gardenia Change-Id: I0c3f21065939d1b13c2607aba16cbef74dd8d389 Signed-off-by: Zheng Bao <fishbaozi@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73020 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/soc/amd/stoneyridge/Makefile.inc')
-rw-r--r--src/soc/amd/stoneyridge/Makefile.inc9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc
index 4d427a3a77..547303b4d2 100644
--- a/src/soc/amd/stoneyridge/Makefile.inc
+++ b/src/soc/amd/stoneyridge/Makefile.inc
@@ -122,14 +122,6 @@ SMUFWM_FN_FILE=
SMUFIRMWARE2_FN_FILE=
endif
-ifeq ($(FIRMWARE_TYPE),ST)
-OPT_COMBOCAPABLE=--combo-capable
-endif
-
-ifeq ($(FIRMWARE_TYPE),CZ)
-OPT_COMBOCAPABLE=--combo-capable
-endif
-
ifeq ($(CONFIG_USE_PSPSECUREOS),y)
PSP_USE_PSPSECUREOS="--use-pspsecureos"
endif
@@ -148,7 +140,6 @@ $(obj)/amdfw.rom: $(call strip_quotes, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE)) \
$(AMDFWTOOL) \
$(OPT_STONEYRIDGE_XHCI_FWM_FILE) \
$(OPT_STONEYRIDGE_GEC_FWM_FILE) \
- $(OPT_COMBOCAPABLE)\
$(OPT_PSP_USE_PSPSECUREOS) \
$(OPT_EFS_SPI_READ_MODE) \
$(OPT_EFS_SPI_SPEED) \