diff options
author | Felix Held <felix.held@amd.corp-partner.google.com> | 2020-05-20 02:42:41 +0200 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2020-05-21 14:39:46 +0000 |
commit | 368873ced315fb00b1052b5e5633d2d157a8f0a1 (patch) | |
tree | 0fe4192bc1301bff6fc3c2a3cfd823dc169e9336 /src/soc/amd/picasso | |
parent | 5640cfdc92b6cfbbeb9f0583a56ebbfaea3b34f7 (diff) |
soc/amd/picasso/soc_util: change return type of soc_is_*
All callers just check for zero/non-zero.
Change-Id: I795763ce882d879d12c97b71e7a0b35423378c36
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41559
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/soc/amd/picasso')
-rw-r--r-- | src/soc/amd/picasso/include/soc/soc_util.h | 12 | ||||
-rw-r--r-- | src/soc/amd/picasso/soc_util.c | 10 |
2 files changed, 12 insertions, 10 deletions
diff --git a/src/soc/amd/picasso/include/soc/soc_util.h b/src/soc/amd/picasso/include/soc/soc_util.h index 9077195a88..6515761a8a 100644 --- a/src/soc/amd/picasso/include/soc/soc_util.h +++ b/src/soc/amd/picasso/include/soc/soc_util.h @@ -3,6 +3,8 @@ #ifndef __PICASSO_SOC_UTIL_H__ #define __PICASSO_SOC_UTIL_H__ +#include <types.h> + enum socket_type { SOCKET_FP5 = 0, SOCKET_AM4 = 2, @@ -11,10 +13,10 @@ enum socket_type { void print_socket_type(void); -int soc_is_pollock(void); -int soc_is_dali(void); -int soc_is_picasso(void); -int soc_is_raven2(void); -int soc_is_zen_plus(void); +bool soc_is_pollock(void); +bool soc_is_dali(void); +bool soc_is_picasso(void); +bool soc_is_raven2(void); +bool soc_is_zen_plus(void); #endif /* __PICASSO_SOC_UTIL_H__ */ diff --git a/src/soc/amd/picasso/soc_util.c b/src/soc/amd/picasso/soc_util.c index f82811053c..89aa0a40ff 100644 --- a/src/soc/amd/picasso/soc_util.c +++ b/src/soc/amd/picasso/soc_util.c @@ -37,7 +37,7 @@ void print_socket_type(void) } } -int soc_is_pollock(void) +bool soc_is_pollock(void) { return soc_is_zen_plus() && get_socket_type() == SOCKET_FT5; } @@ -46,23 +46,23 @@ int soc_is_pollock(void) * TODO: This detection works for the Dali SKUs used in Chrome-devices, but fails for other * Dali SKUs, since other Dali SKUs have a Zen+ CPUID and not a Raven2 one. */ -int soc_is_dali(void) +bool soc_is_dali(void) { return soc_is_raven2() && get_socket_type() == SOCKET_FP5; } -int soc_is_picasso(void) +bool soc_is_picasso(void) { return soc_is_zen_plus() && get_socket_type() == SOCKET_FP5; } -int soc_is_raven2(void) +bool soc_is_raven2(void) { /* mask lower model number nibble and stepping */ return cpuid_eax(1) >> 8 == RAVEN2_CPUID >> 8; } -int soc_is_zen_plus(void) +bool soc_is_zen_plus(void) { /* mask lower model number nibble and stepping */ return cpuid_eax(1) >> 8 == PICASSO_CPUID >> 8; |