aboutsummaryrefslogtreecommitdiff
path: root/src/soc/amd/common
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-03-30 21:44:39 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-04-01 14:30:50 +0000
commit02512eeb2ee5e0cea75dbd4f91501c998e93cc45 (patch)
tree89503837b654a453eebd7bb774d585ba8eeeda53 /src/soc/amd/common
parentd025ab3bc2e2a9e116bfa43a3abf2f16ed4e7147 (diff)
soc/amd/common/block/i2c/i23c_pad_def.h: fix off by one in define
I23C_PAD_CTRL_SLEW_N_SHIFT is 6 and not 7 which matches both with the PPR #57243 revision 1.53 and with I23C_PAD_CTRL_SLEW_N_MASK which covers both bits 6 and 7. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I622717bebaffe34b6df5e578b082dc10e2a98256 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63216 Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common')
-rw-r--r--src/soc/amd/common/block/i2c/i23c_pad_def.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/block/i2c/i23c_pad_def.h b/src/soc/amd/common/block/i2c/i23c_pad_def.h
index 8973a0c633..ae7f3d6890 100644
--- a/src/soc/amd/common/block/i2c/i23c_pad_def.h
+++ b/src/soc/amd/common/block/i2c/i23c_pad_def.h
@@ -17,7 +17,7 @@
#define I23C_PAD_CTRL_RX_SEL_OFF (0 << I23C_PAD_CTRL_RX_SHIFT)
#define I23C_PAD_CTRL_RX_SEL_ON (3 << I23C_PAD_CTRL_RX_SHIFT)
#define I23C_PAD_CTRL_SLEW_N_MASK (BIT(6) | BIT(7))
-#define I23C_PAD_CTRL_SLEW_N_SHIFT 7
+#define I23C_PAD_CTRL_SLEW_N_SHIFT 6
#define I23C_PAD_CTRL_SLEW_N_DIS (0 << I23C_PAD_CTRL_SLEW_N_SHIFT)
#define I23C_PAD_CTRL_SLEW_N_FAST (3 << I23C_PAD_CTRL_SLEW_N_SHIFT)
#define I23C_PAD_CTRL_FALLSLEW_SEL_MASK (BIT(8) | BIT(9))