diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/northbridge | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/amd/agesa/family14/northbridge.c | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/gm45/raminit.c | 3 | ||||
| -rw-r--r-- | src/northbridge/intel/i945/gma.c | 4 | ||||
| -rw-r--r-- | src/northbridge/intel/sandybridge/common.c | 2 |
4 files changed, 5 insertions, 6 deletions
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 4b4ab679d9..2d9597eba6 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -625,7 +625,7 @@ static void cpu_bus_scan(struct device *dev) /* There is only one node for fam14, but there may be multiple cores. */ cpu = pcidev_on_root(0x18, 0); if (!cpu) - printk(BIOS_ERR, "ERROR: %02x:%02x.0 not found", 0, 0x18); + printk(BIOS_ERR, "%02x:%02x.0 not found", 0, 0x18); cores_found = (pci_read_config32(pcidev_on_root(0x18, 0x3), 0xe8) >> 12) & 3; diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c index e7663b99aa..6e505da7bc 100644 --- a/src/northbridge/intel/gm45/raminit.c +++ b/src/northbridge/intel/gm45/raminit.c @@ -195,8 +195,7 @@ void enter_raminit_or_reset(void) if (reg8 & (1 << 2)) { /* S4-assertion-width violation */ /* Ignore S4-assertion-width violation like original BIOS. */ - printk(BIOS_WARNING, - "WARNING: Ignoring S4-assertion-width violation.\n"); + printk(BIOS_WARNING, "Ignoring S4-assertion-width violation.\n"); /* Bit2 is R/WC, so it will clear itself below. */ } diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 99d3c21e36..d094a6789f 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -328,7 +328,7 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf, write32(mmiobase + EIR, 0xffffffff); if (gtt_setup(mmiobase)) { - printk(BIOS_ERR, "ERROR: GTT Setup Failed!!!\n"); + printk(BIOS_ERR, "GTT Setup Failed!!!\n"); return 0; } @@ -352,7 +352,7 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf, if (temp & 1) printk(BIOS_INFO, "GTT Enabled\n"); else - printk(BIOS_ERR, "ERROR: GTT is still Disabled!!!\n"); + printk(BIOS_ERR, "GTT is still Disabled!!!\n"); if (CONFIG(LINEAR_FRAMEBUFFER)) { printk(BIOS_SPEW, "memset %p to 0x00 for %d bytes\n", diff --git a/src/northbridge/intel/sandybridge/common.c b/src/northbridge/intel/sandybridge/common.c index 5cd49cc9a6..a8f718c184 100644 --- a/src/northbridge/intel/sandybridge/common.c +++ b/src/northbridge/intel/sandybridge/common.c @@ -9,7 +9,7 @@ enum platform_type get_platform_type(void) { const int id = get_platform_id(); if (id != 1 && id != 4) - printk(BIOS_WARNING, "WARN: Unknown platform id 0x%x\n", id); + printk(BIOS_WARNING, "Unknown platform id 0x%x\n", id); return (id == 4) ? PLATFORM_MOBILE : PLATFORM_DESKTOP_SERVER; } |