diff options
| author | Bill XIE <persmule@hardenedlinux.org> | 2023-04-04 10:59:13 +0800 |
|---|---|---|
| committer | Jakub Czapiga <jacz@semihalf.com> | 2023-04-05 10:02:55 +0000 |
| commit | 9c3407b99d99f6bfbdace345c070b35eb661f66f (patch) | |
| tree | 9de87ddfaade99f83690e3b3d46769af84c9243d /src/northbridge | |
| parent | 9e45e32420eda750afea9f6e4a3e6de42ba4152b (diff) | |
nb/intel/gm45: Prevent null-deref in get_blc_pwm_freq_value()
IF its first call is get_blc_pwm_freq_value(NULL), null dereference
will occur.
Now when the parameter is NULL, it will return the value of the static
blc_pwm_freq directly, so the original behavior is kept.
Signed-off-by: Bill XIE <persmule@hardenedlinux.org>
Change-Id: I32354aa0fe1a3ca725c2031f973ffad0bda81ad5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74179
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/intel/gm45/gma.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 7df9106f2f..804382224d 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -67,7 +67,8 @@ u16 get_blc_pwm_freq_value(const char *edid_ascii_string) int i; int blc_array_len; - if (blc_pwm_freq > 0) + /* Prevent null-deref on strcmp() below */ + if (blc_pwm_freq > 0 || !edid_ascii_string) return blc_pwm_freq; blc_array_len = get_blc_values(&blc_pwm); |