summaryrefslogtreecommitdiff
path: root/src/northbridge
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2022-11-15 14:00:22 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-11-17 13:33:33 +0000
commit8d14633dfb21b6789814e1c3ca6700d4be7e50b6 (patch)
tree9dd8b8da7599a27f6ca575703364e3f339670277 /src/northbridge
parent0427788e2449abb1ebc318dc5e93d6aa5cc0aa6d (diff)
nb/intel/ironlake,sandybridge/gma: Fix out() parameter order
Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69670 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/northbridge')
-rw-r--r--src/northbridge/intel/ironlake/gma.c6
-rw-r--r--src/northbridge/intel/sandybridge/gma.c6
2 files changed, 6 insertions, 6 deletions
diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c
index 8084560636..fb21d35b55 100644
--- a/src/northbridge/intel/ironlake/gma.c
+++ b/src/northbridge/intel/ironlake/gma.c
@@ -122,15 +122,15 @@ static void gma_enable_swsci(void)
/* clear DMISCI status */
reg16 = inw(DEFAULT_PMBASE + TCO1_STS);
reg16 &= DMISCI_STS;
- outw(DEFAULT_PMBASE + TCO1_STS, reg16);
+ outw(reg16, DEFAULT_PMBASE + TCO1_STS);
/* clear acpi tco status */
- outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS);
+ outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS);
/* enable acpi tco scis */
reg16 = inw(DEFAULT_PMBASE + GPE0_EN);
reg16 |= TCOSCI_EN;
- outw(DEFAULT_PMBASE + GPE0_EN, reg16);
+ outw(reg16, DEFAULT_PMBASE + GPE0_EN);
}
static void gma_func0_init(struct device *dev)
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index d1b9263980..3eed5cc9bc 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -570,15 +570,15 @@ static void gma_enable_swsci(void)
/* Clear DMISCI status */
reg16 = inw(DEFAULT_PMBASE + TCO1_STS);
reg16 &= DMISCI_STS;
- outw(DEFAULT_PMBASE + TCO1_STS, reg16);
+ outw(reg16, DEFAULT_PMBASE + TCO1_STS);
/* Clear ACPI TCO status */
- outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS);
+ outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS);
/* Enable ACPI TCO SCIs */
reg16 = inw(DEFAULT_PMBASE + GPE0_EN);
reg16 |= TCOSCI_EN;
- outw(DEFAULT_PMBASE + GPE0_EN, reg16);
+ outw(reg16, DEFAULT_PMBASE + GPE0_EN);
}
static void gma_func0_init(struct device *dev)