summaryrefslogtreecommitdiff
path: root/src/northbridge/intel/haswell/raminit.c
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-01-31 15:06:59 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-01 08:22:10 +0000
commit6724ba4f045cbbe2326463cbeaf59becfb01342e (patch)
tree4cb8b3e230978d69e75b866b4e0c5eddf7e75600 /src/northbridge/intel/haswell/raminit.c
parent69ff4281596127622f4ef941a37d80baec4f65b1 (diff)
memory_info.h: Store SMBIOS error correction type
There are platforms that support error correction types other than single-bit ECC. Extend meminfo to accomodate additional ECC types. It is assumed that `struct memory_info` is packed to save space. Thus, use `uint8_t` instead of an enum type (which are usually 4 bytes wide). Change-Id: I863f8e34c84841d931dfb8d7067af0f12a437e36 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50178 Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge/intel/haswell/raminit.c')
-rw-r--r--src/northbridge/intel/haswell/raminit.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c
index 96e6a2aeff..58ac8a05a3 100644
--- a/src/northbridge/intel/haswell/raminit.c
+++ b/src/northbridge/intel/haswell/raminit.c
@@ -167,9 +167,9 @@ void sdram_initialize(struct pei_data *pei_data)
report_memory_config();
}
-static bool nb_supports_ecc(const uint32_t capid0_a)
+static uint8_t nb_get_ecc_type(const uint32_t capid0_a)
{
- return !(capid0_a & CAPID_ECCDIS);
+ return capid0_a & CAPID_ECCDIS ? MEMORY_ARRAY_ECC_NONE : MEMORY_ARRAY_ECC_SINGLE_BIT;
}
static uint16_t nb_slots_per_channel(const uint32_t capid0_a)
@@ -256,7 +256,7 @@ void setup_sdram_meminfo(struct pei_data *pei_data)
const uint16_t channels = nb_number_of_channels(capid0_a);
- mem_info->ecc_capable = nb_supports_ecc(capid0_a);
+ mem_info->ecc_type = nb_get_ecc_type(capid0_a);
mem_info->max_capacity_mib = channels * nb_max_chan_capacity_mib(capid0_a);
mem_info->number_of_devices = channels * nb_slots_per_channel(capid0_a);
}