summaryrefslogtreecommitdiff
path: root/src/northbridge/amd/pi/00670F00
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2016-12-01 22:08:18 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2016-12-07 12:59:28 +0100
commit6f66f414a0907f79abf492cd9eca839c0849c7f6 (patch)
tree3e74145128261014798af58111db31d616fd43dd /src/northbridge/amd/pi/00670F00
parent891b6c4d199418a08ba88e42d6c8945ce05205f1 (diff)
PCI ops: MMCONF_SUPPORT_DEFAULT is required
Doing PCI config operations via MMIO window by default is a requirement, if supported by the platform. This means chipset or CPU code must enable MMCONF operations early in bootblock already, or before platform-specific romstage entry. Platforms are allowed to have NO_MMCONF_SUPPORT only in the case it is actually not implemented in the silicon. Change-Id: Id4d9029dec2fe195f09373320de800fcdf88c15d Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/17693 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/northbridge/amd/pi/00670F00')
-rw-r--r--src/northbridge/amd/pi/00670F00/northbridge.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/northbridge/amd/pi/00670F00/northbridge.c b/src/northbridge/amd/pi/00670F00/northbridge.c
index ce0dde3e5c..9a39410f49 100644
--- a/src/northbridge/amd/pi/00670F00/northbridge.c
+++ b/src/northbridge/amd/pi/00670F00/northbridge.c
@@ -330,8 +330,7 @@ static void read_resources(device_t dev)
* It is not honored by the coreboot resource allocator if it is in
* the CPU_CLUSTER.
*/
- if (IS_ENABLED(CONFIG_MMCONF_SUPPORT))
- enable_mmconf_resource(dev);
+ enable_mmconf_resource(dev);
}
static void set_resource(device_t dev, struct resource *resource, u32 nodeid)