diff options
author | Nico Huber <nico.huber@secunet.com> | 2017-11-01 09:49:16 +0100 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2019-03-16 16:22:16 +0000 |
commit | ebd8a4f90cf58cd03a95fcc01acea1c59b0cad4e (patch) | |
tree | cdff8fbc8e89cbe96236a00195856c135d151705 /src/mainboard | |
parent | 4663f45caa2352760ee08ec28b9c2d6e2e8823f9 (diff) |
x86/smbios: Untangle system and board tables
We were used to set the same values in the system and board tables.
We'll keep the mainboard values as defaults for the system tables,
so nothing changes unless somebody overrides the system table hooks.
Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/29477
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Diffstat (limited to 'src/mainboard')
-rw-r--r-- | src/mainboard/emulation/qemu-i440fx/fw_cfg.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/fizz/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/hatch/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/kahlee/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/octopus/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/poppy/variants/nami/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/poppy/variants/nautilus/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/poppy/variants/rammus/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/reef/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/google/sarien/sku.c | 2 | ||||
-rw-r--r-- | src/mainboard/pcengines/apu1/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/pcengines/apu2/mainboard.c | 2 | ||||
-rw-r--r-- | src/mainboard/scaleway/tagada/ramstage.c | 4 |
13 files changed, 14 insertions, 14 deletions
diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index a83c581746..3acb11e5f5 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -495,7 +495,7 @@ const char *smbios_mainboard_serial_number(void) return type1_serial_number ?: CONFIG_MAINBOARD_SERIAL_NUMBER; } -void smbios_mainboard_set_uuid(u8 *uuid) +void smbios_system_set_uuid(u8 *uuid) { fw_cfg_smbios_init(); memcpy(uuid, type1_uuid, 16); diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 5670936021..54fd7dfe6d 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -177,7 +177,7 @@ static uint8_t board_oem_id(void) return oem_id; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[5]; /* sku{0..7} */ diff --git a/src/mainboard/google/hatch/mainboard.c b/src/mainboard/google/hatch/mainboard.c index a0fbb73f43..eb77a0030b 100644 --- a/src/mainboard/google/hatch/mainboard.c +++ b/src/mainboard/google/hatch/mainboard.c @@ -36,7 +36,7 @@ static uint32_t get_board_sku(void) return sku_id; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[7]; /* sku{0..255} */ uint32_t sku_id = get_board_sku(); diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 32bf88e54c..1bf6c07045 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -216,7 +216,7 @@ void __weak variant_mainboard_suspend_resume(void) { } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[7]; /* sku{0..255} */ diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c index 5b011c8f19..4316ffed23 100644 --- a/src/mainboard/google/octopus/mainboard.c +++ b/src/mainboard/google/octopus/mainboard.c @@ -131,7 +131,7 @@ static uint32_t get_board_sku(void) return sku_id; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[7]; /* sku{0..255} */ uint32_t sku_id = get_board_sku(); diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index e279693511..836c97ea40 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -104,7 +104,7 @@ uint32_t variant_board_sku(void) return sku_id; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[14]; /* sku{0..4294967295} */ diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index 08fb73f932..6d9f2e99a9 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -28,7 +28,7 @@ #define B_PCH_OC_WDT_CTL_EN BIT14 #define B_PCH_OC_WDT_CTL_UNXP_RESET_STS BIT22 -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[5]; /* sku{0-1} */ diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index a3474d4666..5c5b258885 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -34,7 +34,7 @@ uint32_t variant_board_sku(void) return sku_id; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[14]; /* sku{0..4294967295} */ diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 05af84a03e..20b6a26459 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -88,7 +88,7 @@ void __weak variant_board_ec_set_skuid(void) { } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku_str[7]; /* sku{0..255} */ diff --git a/src/mainboard/google/sarien/sku.c b/src/mainboard/google/sarien/sku.c index c064c02ef7..708793db9e 100644 --- a/src/mainboard/google/sarien/sku.c +++ b/src/mainboard/google/sarien/sku.c @@ -22,7 +22,7 @@ uint32_t sku_id(void) return VARIANT_SKU_ID; } -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { return VARIANT_SKU_NAME; } diff --git a/src/mainboard/pcengines/apu1/mainboard.c b/src/mainboard/pcengines/apu1/mainboard.c index 10460bd6f2..79a54b51eb 100644 --- a/src/mainboard/pcengines/apu1/mainboard.c +++ b/src/mainboard/pcengines/apu1/mainboard.c @@ -263,7 +263,7 @@ static void usb_oc_setup(void) /* * We will stuff the memory size into the smbios sku location. */ -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku[5]; if (sku[0] != 0) diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index 472b864bd9..5a19d20efc 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -235,7 +235,7 @@ const char *smbios_mainboard_serial_number(void) /* * We will stuff the memory size into the smbios sku location. */ -const char *smbios_mainboard_sku(void) +const char *smbios_system_sku(void) { static char sku[5]; if (sku[0] != 0) diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c index 561c081d4b..d592d99cf4 100644 --- a/src/mainboard/scaleway/tagada/ramstage.c +++ b/src/mainboard/scaleway/tagada/ramstage.c @@ -41,8 +41,8 @@ const char *smbios_mainboard_serial_number(void) return CONFIG_MAINBOARD_SERIAL_NUMBER; } -/* Override smbios_mainboard_set_uuid */ -void smbios_mainboard_set_uuid(u8 *uuid) +/* Override smbios_system_set_uuid */ +void smbios_system_set_uuid(u8 *uuid) { const u8 *bmc_uuid = bmcinfo_uuid(); if (bmc_uuid) |