summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-08-30 10:33:50 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-09-03 00:12:37 +0000
commitb4d3a1436070e9388caed6fd0756b5009219f31d (patch)
tree55b09e0c18f991acb3f6736ad43d1d34240135ea /src/mainboard
parent8f4098bb3dfa069ae330257c7cd677806634ea4a (diff)
skylake: Default to `BOARD_TYPE_DESKTOP` for PCH-H
Set the `UserBd` FSP-M UPD to `BOARD_TYPE_DESKTOP` by default on PCH-H. Remove now-redundant mainboard code to set the `UserBd` UPD. Change-Id: I349abe5d89f562c158ce9baadbca2b2f56695846 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/57261 Reviewed-by: Felix Singer <felixsinger@posteo.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/asrock/h110m/romstage.c3
-rw-r--r--src/mainboard/hp/280_g2/romstage.c1
-rw-r--r--src/mainboard/intel/kblrvp/romstage.c1
3 files changed, 0 insertions, 5 deletions
diff --git a/src/mainboard/asrock/h110m/romstage.c b/src/mainboard/asrock/h110m/romstage.c
index ca3058fa9f..f78aa30b21 100644
--- a/src/mainboard/asrock/h110m/romstage.c
+++ b/src/mainboard/asrock/h110m/romstage.c
@@ -33,7 +33,4 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
/* use virtual channel 1 for the dmi interface of the PCH */
mupd->FspmTestConfig.DmiVc1 = 1;
-
- /* desktop type */
- mem_cfg->UserBd = BOARD_TYPE_DESKTOP;
}
diff --git a/src/mainboard/hp/280_g2/romstage.c b/src/mainboard/hp/280_g2/romstage.c
index 9b3d385b42..130eb14f6d 100644
--- a/src/mainboard/hp/280_g2/romstage.c
+++ b/src/mainboard/hp/280_g2/romstage.c
@@ -25,7 +25,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
mem_cfg->CaVrefConfig = 2;
mem_cfg->DqPinsInterleaved = true;
- mem_cfg->UserBd = BOARD_TYPE_DESKTOP;
mem_cfg->MemorySpdDataLen = blk.len;
mem_cfg->MemorySpdPtr00 = (u32)blk.spd_array[0];
diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c
index bc4c6de661..fb02f21edc 100644
--- a/src/mainboard/intel/kblrvp/romstage.c
+++ b/src/mainboard/intel/kblrvp/romstage.c
@@ -50,7 +50,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
case BOARD_ID_KBL_RVP11:
mem_cfg->MemorySpdPtr01 = (uintptr_t)blk.spd_array[1];
mem_cfg->MemorySpdPtr11 = (uintptr_t)blk.spd_array[3];
- mem_cfg->UserBd = BOARD_TYPE_DESKTOP;
break;
default:
break;