diff options
| author | Felix Singer <felixsinger@posteo.net> | 2021-12-31 00:15:18 +0100 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-05-26 11:48:28 +0000 |
| commit | 8ba9410c69dbdb9e37bd7c8de2a523f7cfa7a76a (patch) | |
| tree | 48a7fce684f8bde1b30fdf9d1965175c0181a3cf /src/mainboard | |
| parent | edb1a4012700df227dcf5780b5f45fcf9c2a1625 (diff) | |
soc/intel/cannonlake: Hook up FSP hyper-threading setting to option API
Select `HAVE_HYPERTHREADING` and hook up the hyper-threading setting
from the FSP to the option API so that related mainboards don't have to
do that. Unless otherwise configured (e.g. the CMOS setting or overriden
by the mainboard code), the value from the Kconfig setting
`FSP_HYPERTHREADING` is used.
Also, remove related code from the following mainboards, since it is
obsolete now.
* siemens/chili
* starlabs/laptop/cml
Change-Id: I173b87da5ce76549672c50ba30204cd77be8b82f
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60544
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/siemens/chili/romstage.c | 2 | ||||
| -rw-r--r-- | src/mainboard/starlabs/labtop/variants/cml/romstage.c | 4 |
2 files changed, 0 insertions, 6 deletions
diff --git a/src/mainboard/siemens/chili/romstage.c b/src/mainboard/siemens/chili/romstage.c index ddcc2cc87c..6f36a7f9e3 100644 --- a/src/mainboard/siemens/chili/romstage.c +++ b/src/mainboard/siemens/chili/romstage.c @@ -26,8 +26,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) const uint8_t vtd = get_uint_option("vtd", 1); memupd->FspmTestConfig.VtdDisable = !vtd; - const uint8_t ht = get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading); - memupd->FspmConfig.HyperThreading = ht; variant_romstage_params(memupd); diff --git a/src/mainboard/starlabs/labtop/variants/cml/romstage.c b/src/mainboard/starlabs/labtop/variants/cml/romstage.c index 189b7f378c..75a19e576b 100644 --- a/src/mainboard/starlabs/labtop/variants/cml/romstage.c +++ b/src/mainboard/starlabs/labtop/variants/cml/romstage.c @@ -73,10 +73,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) const uint8_t vtd = get_uint_option("vtd", 1); memupd->FspmTestConfig.VtdDisable = !vtd; - const uint8_t ht = - get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading); - memupd->FspmConfig.HyperThreading = ht; - fill_spd_data(&memcfg); cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg); } |