soc/intel/bdw,nb/intel/hsw: convert panel delays to ms representation

For easier review of the switch to a new register struct in the
follow-up change, the panel delay times get converted from destination
register raw format to milliseconds representation in this change.

Formula for conversion of power cycle delay:

  gpu_panel_power_cycle_delay_ms =
    (gpu_panel_power_cycle_delay - 1) * 100

Formula for all others:

  gpu_panel_power_X_delay_ms = gpu_panel_power_X_delay / 10

The register names gain a suffix `_ms` and calculation of the
destination register raw values gets done in gma code now.

Change-Id: Idf8e076dac2b3048a63a0109263a6e7899f07230
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48958
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

13 files changed, 65 insertions, 65 deletions

diff --git a/src/mainboard/google/auron/variants/auron_paine/overridetree.cb b/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
index 81110408c1..cb7fb62b34 100644
--- a/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
+++ b/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
@@ -1,11 +1,11 @@
 chip soc/intel/broadwell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "70"	# 7ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "7"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 		chip soc/intel/broadwell/pch
diff --git a/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb b/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
index eb33d433e8..746ec9a58f 100644
--- a/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
+++ b/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
@@ -1,11 +1,11 @@
 chip soc/intel/broadwell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "2100"	# 210ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "210"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 		chip soc/intel/broadwell/pch
diff --git a/src/mainboard/google/auron/variants/buddy/overridetree.cb b/src/mainboard/google/auron/variants/buddy/overridetree.cb
index 60fb08cbf7..5423043cd8 100644
--- a/src/mainboard/google/auron/variants/buddy/overridetree.cb
+++ b/src/mainboard/google/auron/variants/buddy/overridetree.cb
@@ -1,11 +1,11 @@
 chip soc/intel/broadwell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "70"	# 7ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "7"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	register "s0ix_enable" = "0"
 
diff --git a/src/mainboard/google/auron/variants/gandof/overridetree.cb b/src/mainboard/google/auron/variants/gandof/overridetree.cb
index c7e2421ee8..19c0ca0003 100644
--- a/src/mainboard/google/auron/variants/gandof/overridetree.cb
+++ b/src/mainboard/google/auron/variants/gandof/overridetree.cb
@@ -1,11 +1,11 @@
 chip soc/intel/broadwell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "500"	# 50ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "50"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 		chip soc/intel/broadwell/pch
diff --git a/src/mainboard/google/auron/variants/lulu/overridetree.cb b/src/mainboard/google/auron/variants/lulu/overridetree.cb
index 81110408c1..cb7fb62b34 100644
--- a/src/mainboard/google/auron/variants/lulu/overridetree.cb
+++ b/src/mainboard/google/auron/variants/lulu/overridetree.cb
@@ -1,11 +1,11 @@
 chip soc/intel/broadwell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "70"	# 7ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "7"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 		chip soc/intel/broadwell/pch
diff --git a/src/mainboard/google/auron/variants/samus/overridetree.cb b/src/mainboard/google/auron/variants/samus/overridetree.cb
index d8aec0ae04..989b887628 100644
--- a/src/mainboard/google/auron/variants/samus/overridetree.cb
+++ b/src/mainboard/google/auron/variants/samus/overridetree.cb
@@ -4,11 +4,11 @@ chip soc/intel/broadwell
 	register "gpu_dp_c_hotplug" = "0x06"
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "6"		# 500ms
-	register "gpu_panel_power_up_delay" = "2000"		# 200ms
-	register "gpu_panel_power_down_delay" = "500"		# 50ms
-	register "gpu_panel_power_backlight_on_delay" = "2000"	# 200ms
-	register "gpu_panel_power_backlight_off_delay" = "2000"	# 200ms
+	register "gpu_panel_power_cycle_delay_ms" = "500"
+	register "gpu_panel_power_up_delay_ms" = "200"
+	register "gpu_panel_power_down_delay_ms" = "50"
+	register "gpu_panel_power_backlight_on_delay_ms" = "200"
+	register "gpu_panel_power_backlight_off_delay_ms" = "200"
 
 	register "vr_slow_ramp_rate_set" = "3"
 	register "vr_slow_ramp_rate_enable" = "1"
diff --git a/src/mainboard/google/slippy/variants/falco/overridetree.cb b/src/mainboard/google/slippy/variants/falco/overridetree.cb
index 7df0ca1a6f..54ae6151d2 100644
--- a/src/mainboard/google/slippy/variants/falco/overridetree.cb
+++ b/src/mainboard/google/slippy/variants/falco/overridetree.cb
@@ -1,11 +1,11 @@
 chip northbridge/intel/haswell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms (T4)
-	register "gpu_panel_power_up_delay" = "600"		# 60ms  (T1+T2)
-	register "gpu_panel_power_down_delay" = "600"		# 60ms  (T3+T7)
-	register "gpu_panel_power_backlight_on_delay" = "2100"	# 210ms (T5)
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms (T6)
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "60"
+	register "gpu_panel_power_down_delay_ms" = "60"
+	register "gpu_panel_power_backlight_on_delay_ms" = "210"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 
diff --git a/src/mainboard/google/slippy/variants/leon/overridetree.cb b/src/mainboard/google/slippy/variants/leon/overridetree.cb
index 6dee38e36e..9c45f0062b 100644
--- a/src/mainboard/google/slippy/variants/leon/overridetree.cb
+++ b/src/mainboard/google/slippy/variants/leon/overridetree.cb
@@ -1,11 +1,11 @@
 chip northbridge/intel/haswell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "2100"	# 210ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "210"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 
diff --git a/src/mainboard/google/slippy/variants/peppy/overridetree.cb b/src/mainboard/google/slippy/variants/peppy/overridetree.cb
index 689fee4cf3..47edc62397 100644
--- a/src/mainboard/google/slippy/variants/peppy/overridetree.cb
+++ b/src/mainboard/google/slippy/variants/peppy/overridetree.cb
@@ -1,11 +1,11 @@
 chip northbridge/intel/haswell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "5"		# 400ms
-	register "gpu_panel_power_up_delay" = "400"		# 40ms
-	register "gpu_panel_power_down_delay" = "150"		# 15ms
-	register "gpu_panel_power_backlight_on_delay" = "2100"	# 210ms
-	register "gpu_panel_power_backlight_off_delay" = "2100"	# 210ms
+	register "gpu_panel_power_cycle_delay_ms" = "400"
+	register "gpu_panel_power_up_delay_ms" = "40"
+	register "gpu_panel_power_down_delay_ms" = "15"
+	register "gpu_panel_power_backlight_on_delay_ms" = "210"
+	register "gpu_panel_power_backlight_off_delay_ms" = "210"
 
 	device domain 0 on
 
diff --git a/src/mainboard/google/slippy/variants/wolf/overridetree.cb b/src/mainboard/google/slippy/variants/wolf/overridetree.cb
index de61839cc7..43bdf561d6 100644
--- a/src/mainboard/google/slippy/variants/wolf/overridetree.cb
+++ b/src/mainboard/google/slippy/variants/wolf/overridetree.cb
@@ -1,11 +1,11 @@
 chip northbridge/intel/haswell
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "6"		# 500ms (T11+T12)
-	register "gpu_panel_power_up_delay" = "2000"		# 200ms (T3)
-	register "gpu_panel_power_down_delay" = "500"		# 50ms (T10)
-	register "gpu_panel_power_backlight_on_delay" = "10"	# 1ms (T8)
-	register "gpu_panel_power_backlight_off_delay" = "2000"	# 200ms (T9)
+	register "gpu_panel_power_cycle_delay_ms" = "500"
+	register "gpu_panel_power_up_delay_ms" = "200"
+	register "gpu_panel_power_down_delay_ms" = "50"
+	register "gpu_panel_power_backlight_on_delay_ms" = "1"
+	register "gpu_panel_power_backlight_off_delay_ms" = "200"
 
 	device domain 0 on
 
diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb
index 140aa844f5..9baec90d64 100644
--- a/src/mainboard/hp/folio_9480m/devicetree.cb
+++ b/src/mainboard/hp/folio_9480m/devicetree.cb
@@ -4,11 +4,11 @@ chip northbridge/intel/haswell
 	register "gfx" = "GMA_STATIC_DISPLAYS(0)"
 	register "gpu_dp_b_hotplug" = "4"
 	register "gpu_dp_c_hotplug" = "4"
-	register "gpu_panel_power_backlight_off_delay" = "1"
-	register "gpu_panel_power_backlight_on_delay" = "1"
-	register "gpu_panel_power_cycle_delay" = "6"
-	register "gpu_panel_power_down_delay" = "500"
-	register "gpu_panel_power_up_delay" = "2000"
+	register "gpu_panel_power_backlight_off_delay_ms" = "1"
+	register "gpu_panel_power_backlight_on_delay_ms" = "1"
+	register "gpu_panel_power_cycle_delay_ms" = "500"
+	register "gpu_panel_power_down_delay_ms" = "50"
+	register "gpu_panel_power_up_delay_ms" = "200"
 	register "gpu_pch_backlight_pwm_hz" = "200"
 	register "usb_xhci_on_resume" = "true"
 	device cpu_cluster 0 on
diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb
index 9359bb4e5d..e17807f247 100644
--- a/src/mainboard/lenovo/t440p/devicetree.cb
+++ b/src/mainboard/lenovo/t440p/devicetree.cb
@@ -4,11 +4,11 @@ chip northbridge/intel/haswell
 	register "gpu_dp_b_hotplug" = "4"
 	register "gpu_dp_c_hotplug" = "4"
 	register "gpu_dp_d_hotplug" = "4"
-	register "gpu_panel_power_backlight_off_delay" = "1"
-	register "gpu_panel_power_backlight_on_delay" = "1"
-	register "gpu_panel_power_cycle_delay" = "6"
-	register "gpu_panel_power_down_delay" = "500"
-	register "gpu_panel_power_up_delay" = "2000"
+	register "gpu_panel_power_backlight_off_delay_ms" = "1"
+	register "gpu_panel_power_backlight_on_delay_ms" = "1"
+	register "gpu_panel_power_cycle_delay_ms" = "500"
+	register "gpu_panel_power_down_delay_ms" = "50"
+	register "gpu_panel_power_up_delay_ms" = "200"
 	register "gpu_pch_backlight_pwm_hz" = "220"
 	register "ec_present" = "true"
 	device cpu_cluster 0x0 on
diff --git a/src/mainboard/purism/librem_bdw/devicetree.cb b/src/mainboard/purism/librem_bdw/devicetree.cb
index 0d0fc720f7..41943e72ef 100644
--- a/src/mainboard/purism/librem_bdw/devicetree.cb
+++ b/src/mainboard/purism/librem_bdw/devicetree.cb
@@ -10,11 +10,11 @@ chip soc/intel/broadwell
 	register "gpu_pch_backlight_pwm_hz" = "200"
 
 	# Set panel power delays
-	register "gpu_panel_power_cycle_delay" = "6"		# 500ms
-	register "gpu_panel_power_up_delay" = "2000"		# 200ms
-	register "gpu_panel_power_down_delay" = "500"		# 50ms
-	register "gpu_panel_power_backlight_on_delay" = "2000"	# 200ms
-	register "gpu_panel_power_backlight_off_delay" = "2000"	# 200ms
+	register "gpu_panel_power_cycle_delay_ms" = "500"
+	register "gpu_panel_power_up_delay_ms" = "200"
+	register "gpu_panel_power_down_delay_ms" = "50"
+	register "gpu_panel_power_backlight_on_delay_ms" = "200"
+	register "gpu_panel_power_backlight_off_delay_ms" = "200"
 
 	device cpu_cluster 0 on
 		device lapic 0 on end