diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-11-24 15:03:38 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-11-30 08:01:57 +0000 |
| commit | 329ebb340b157bc64065473a960a97eae0e30914 (patch) | |
| tree | bdc29060a6b5f6a1f86bf202f92cdefb10ea076e /src/mainboard | |
| parent | 1e678169616b959921c38a2f25ca23b7f3e4cc77 (diff) | |
mb/prodrive/hermes: Use C-style comments
Most of the existing comments are C-style already.
Change-Id: I9ca4779f5b0560320e9bce4f33e54766522689f9
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47957
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/mainboard')
5 files changed, 8 insertions, 8 deletions
diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c index bd5db5c851..94811f68d1 100644 --- a/src/mainboard/prodrive/hermes/eeprom.c +++ b/src/mainboard/prodrive/hermes/eeprom.c @@ -14,7 +14,7 @@ int check_signature(u8 addr) u8 blob[8] = {0}; if (!read_write_config(addr, blob, EEPROM_OFFSET_FSP_SIGNATURE, 0, ARRAY_SIZE(blob))) { - // Check Signature + /* Check signature */ if (*(uint64_t *)blob == FSP_UPD_SIGNATURE) { printk(BIOS_DEBUG, "CFG EEPROM: Signature valid.\n"); return 1; @@ -25,7 +25,7 @@ int check_signature(u8 addr) return 0; } -// Read data from offset and write it to offset in UPD +/* Read data from offset and write it to offset in UPD */ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_offset, size_t size) { @@ -52,7 +52,7 @@ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_off if (ret < 0) break; - // Write to UPD + /* Write to UPD */ uint8_t *writePointer = (uint8_t *)blob + write_offset + i; if (size > 1 && (size % 2 == 0)) memcpy(writePointer, tmp, 2); diff --git a/src/mainboard/prodrive/hermes/ramstage.c b/src/mainboard/prodrive/hermes/ramstage.c index 18fc915018..135d7754aa 100644 --- a/src/mainboard/prodrive/hermes/ramstage.c +++ b/src/mainboard/prodrive/hermes/ramstage.c @@ -5,7 +5,7 @@ #include "variants/baseboard/include/eeprom.h" static fsp_params parmas_list[] = { - // FIXME: Fill with additional options + /* FIXME: Fill with additional options */ }; void mainboard_silicon_init_params(FSP_S_CONFIG *params) @@ -19,7 +19,7 @@ void mainboard_silicon_init_params(FSP_S_CONFIG *params) params->SataLedEnable = 1; - // Overwrite params + /* Overwrite params */ if (!check_signature(I2C_ADDR_EEPROM)) return; diff --git a/src/mainboard/prodrive/hermes/romstage.c b/src/mainboard/prodrive/hermes/romstage.c index a25c43a743..2bcd27ace0 100644 --- a/src/mainboard/prodrive/hermes/romstage.c +++ b/src/mainboard/prodrive/hermes/romstage.c @@ -18,7 +18,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) memupd->FspmConfig.IedSize = 0x400000; cannonlake_memcfg_init(&memupd->FspmConfig, variant_memcfg_config()); - // Overwrite memupd + /* Overwrite memupd */ if (!check_signature(I2C_ADDR_EEPROM)) return; diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c b/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c index 9c01d2470d..8735a9ef4b 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c +++ b/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c @@ -194,7 +194,7 @@ static const struct pad_config gpio_table[] = { /* GPP_K20 - CPU_CATERR_PCH_n */ PAD_CFG_GPI(GPP_K20, NONE, DEEP), /* GPP_K21 - TPM_INT_n */ - PAD_CFG_GPI_INT(GPP_K21, NONE, DEEP, OFF), // Trigger? + PAD_CFG_GPI_INT(GPP_K21, NONE, DEEP, OFF), /* Trigger? */ /* GPP_K22 - NC */ PAD_NC(GPP_K22, NONE), /* GPP_K23 - NC */ diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h index c41ead28ab..79fda3c755 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h +++ b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h @@ -21,7 +21,7 @@ #define EEPROM_OFFSET_FSP_CONFIG (EEPROM_OFFSET_FSP_SIGNATURE + sizeof(FSP_UPD_HEADER)) #define GET_VALUE(x) {.offset = offsetof(FSP_S_CONFIG, x), \ .size = member_size(FSP_S_CONFIG, x)} -#endif // ENV_ROMSTAGE +#endif /* ENV_ROMSTAGE */ typedef struct { size_t offset; |