diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2023-02-16 08:21:15 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-09 21:38:26 +0000 |
| commit | 2285b72d0684f958ab372948d17f2da89db456c7 (patch) | |
| tree | 0c2f78ac00e6ee3846f0b3093c9d3389fafcd6ca /src/mainboard | |
| parent | 132fb3cc52884fa7634d7a9f6406eab3b4ea58d0 (diff) | |
Revert "ec/starlabs/merlin: Add support for enabling the mirror flag"
This reverts commit b42ca4d0b2fafe7214396d30a1a833ac33cf85bc.
Reason for revert: The mirror flag "0x01" is mirror once, which
relies on the EC remembering that it's been mirrored. However, the
EC forgets this if it's been without power for 20 minutes or so.
Even if power is connected then, it'll instantly try to mirror and
it can't charge whilst doing it. It can either result in
incomplete EC firmware, or a loop where it's constantly trying to
mirror.
Change-Id: I79da9143cc63459e7e29431eff2cb14200424b37
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72678
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/starlabs/starbook/Kconfig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 15b2a585e2..d35a4d270f 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -58,7 +58,6 @@ config BOARD_STARLABS_STARBOOK_ADL select DRIVERS_INTEL_PMC select EC_STARLABS_KBL_LEVELS select EC_STARLABS_MAX_CHARGE - select EC_STARLABS_MIRROR_FLAG select EC_STARLABS_NEED_ITE_BIN select MEMORY_MAPPED_TPM select SOC_INTEL_ALDERLAKE |