diff options
| author | Chris Wang <chris.wang@amd.corp-partner.google.com> | 2023-03-04 01:46:25 +0800 |
|---|---|---|
| committer | Eric Lai <eric_lai@quanta.corp-partner.google.com> | 2023-03-07 00:34:01 +0000 |
| commit | 1912a86d1d295e940d57345bf573969096176af6 (patch) | |
| tree | 9325f2602c1ee9e4bbf0c513cd5c9baa8162561a /src/mainboard | |
| parent | 5627ba15cfb58b38beb663681ffd8355f8f5b369 (diff) | |
mb/google/skyrim: Move SPL setting to variants
Move the sustained_power_limit_mW setting from the baseboard
to variants. This setting will be needed before STT is enabled,
but once STT is enabled, this setting should be removed.
BUG=b:265267957
BRANCH=none
TEST=Build/Boot to ChromeOS
Signed-off-by: Chris Wang <chris.wang@amd.corp-partner.google.com>
Change-Id: I7b9779600cfa8c7581732e936a714728fd618d20
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73426
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Diffstat (limited to 'src/mainboard')
4 files changed, 14 insertions, 2 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index c92131c2c3..6892742050 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -260,8 +260,6 @@ chip soc/amd/mendocino register "fast_ppt_limit_mW" = "30000" register "slow_ppt_time_constant_s" = "5" register "stapm_time_constant_s" = "275" - # Remove the sustained_power_limit_mW when STT is enabled - register "sustained_power_limit_mW" = "15000" register "thermctl_limit_degreeC" = "100" register "vrm_current_limit_mA" = "28000" register "vrm_maximum_current_limit_mA" = "50000" diff --git a/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb index 60461c8447..23d7f408b3 100644 --- a/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb @@ -21,6 +21,11 @@ fw_config end chip soc/amd/mendocino + + # Set Package Power Parameters + # Remove the sustained_power_limit_mW when STT is enabled + register "sustained_power_limit_mW" = "15000" + device domain 0 on device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref xhci_1 on # XHCI1 controller diff --git a/src/mainboard/google/skyrim/variants/markarth/overridetree.cb b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb index 5adffd41c8..f82fe1bb30 100644 --- a/src/mainboard/google/skyrim/variants/markarth/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb @@ -2,6 +2,10 @@ chip soc/amd/mendocino + # Set Package Power Parameters + # Remove the sustained_power_limit_mW when STT is enabled + register "sustained_power_limit_mW" = "15000" + device domain 0 on register "dxio_tx_vboost_enable" = "1" diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb index 7b4d76957b..512104da4e 100644 --- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb @@ -27,6 +27,11 @@ fw_config end chip soc/amd/mendocino + + # Set Package Power Parameters + # Remove the sustained_power_limit_mW when STT is enabled + register "sustained_power_limit_mW" = "15000" + device domain 0 on device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref xhci_1 on # XHCI1 controller |