summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2022-07-17 10:22:30 +0200
committerPatrick Georgi <patrick@coreboot.org>2022-07-18 12:44:32 +0000
commit10cd06b1c75e4bc69a1de7e3a70c28ff2e5195fc (patch)
tree955d62a8b6e02c309b5b960fbbcf5644eb1f46e8 /src/mainboard
parentbb5ccbd42fd3e702f71017dd186ae98278ffeeac (diff)
treewide: Don't add bits
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: Id56310bd616cd19fee5dc934676006b2dc34b1ff Reviewed-on: https://review.coreboot.org/c/coreboot/+/65929 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/amd/inagua/BiosCallOuts.c4
-rw-r--r--src/mainboard/amd/south_station/BiosCallOuts.c4
-rw-r--r--src/mainboard/amd/union_station/BiosCallOuts.c4
-rw-r--r--src/mainboard/ocp/deltalake/ramstage.c2
4 files changed, 7 insertions, 7 deletions
diff --git a/src/mainboard/amd/inagua/BiosCallOuts.c b/src/mainboard/amd/inagua/BiosCallOuts.c
index 5eff97d726..72bd046b5b 100644
--- a/src/mainboard/amd/inagua/BiosCallOuts.c
+++ b/src/mainboard/amd/inagua/BiosCallOuts.c
@@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;
diff --git a/src/mainboard/amd/south_station/BiosCallOuts.c b/src/mainboard/amd/south_station/BiosCallOuts.c
index fb4e4d14aa..935e36812f 100644
--- a/src/mainboard/amd/south_station/BiosCallOuts.c
+++ b/src/mainboard/amd/south_station/BiosCallOuts.c
@@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;
diff --git a/src/mainboard/amd/union_station/BiosCallOuts.c b/src/mainboard/amd/union_station/BiosCallOuts.c
index 2d8fb22d5c..9fcecbc6cd 100644
--- a/src/mainboard/amd/union_station/BiosCallOuts.c
+++ b/src/mainboard/amd/union_station/BiosCallOuts.c
@@ -45,7 +45,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG178, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG178);
TempData8 &= 0x23;
@@ -59,7 +59,7 @@ static AGESA_STATUS board_BeforeDramInit(UINT32 Func, UINTN Data, VOID *ConfigPt
TempData8 |= Data8;
Write64Mem8(GpioMmioAddr + SB_GPIO_REG179, TempData8);
- Data8 |= BIT2 + BIT3;
+ Data8 |= BIT2 | BIT3;
Data8 &= ~BIT4;
TempData8 = Read64Mem8(GpioMmioAddr + SB_GPIO_REG179);
TempData8 &= 0x23;
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index d8653b9002..81cc4ec276 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -331,7 +331,7 @@ unsigned int smbios_processor_family(struct cpuid_result res)
unsigned int smbios_processor_characteristics(void)
{
/* 64-bit Capable, Multi-Core, Power/Performance Control */
- return 0x8c; /* BIT2 + BIT3 + BIT7 */
+ return 0x8c; /* BIT2 | BIT3 | BIT7 */
}
static void mainboard_enable(struct device *dev)