summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-04-24 06:41:18 -0700
committerFurquan Shaikh <furquan@google.com>2020-04-28 19:21:49 +0000
commit0f007d8ceb7e5c852c645cf773df5c5c37cbf411 (patch)
tree2891d4d1b03e6a5b5d0695a88bc7272f849cb55e /src/mainboard
parentf939df7a959b645cc79872623d72bed475c21157 (diff)
device: Constify struct device * parameter to write_acpi_tables
.write_acpi_tables() should not be updating the device structure. This change makes the struct device * argument to it as const. Change-Id: I50d013e83a404e0a0e3837ca16fa75c7eaa0e14a Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40701 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/getac/p470/acpi_tables.c2
-rw-r--r--src/mainboard/getac/p470/mainboard.h2
-rw-r--r--src/mainboard/google/dedede/mainboard.c2
-rw-r--r--src/mainboard/google/eve/mainboard.c2
-rw-r--r--src/mainboard/google/fizz/mainboard.c2
-rw-r--r--src/mainboard/google/glados/mainboard.c2
-rw-r--r--src/mainboard/google/octopus/mainboard.c2
-rw-r--r--src/mainboard/google/poppy/mainboard.c2
-rw-r--r--src/mainboard/google/reef/mainboard.c2
-rw-r--r--src/mainboard/intel/cannonlake_rvp/mainboard.c2
-rw-r--r--src/mainboard/intel/coffeelake_rvp/mainboard.c2
-rw-r--r--src/mainboard/intel/glkrvp/mainboard.c2
-rw-r--r--src/mainboard/intel/kunimitsu/mainboard.c2
13 files changed, 13 insertions, 13 deletions
diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c
index c31d76d585..72c18060f0 100644
--- a/src/mainboard/getac/p470/acpi_tables.c
+++ b/src/mainboard/getac/p470/acpi_tables.c
@@ -63,7 +63,7 @@ static long acpi_create_ecdt(acpi_ecdt_t * ecdt)
return header->length;
}
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(const struct device *device,
unsigned long start,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/getac/p470/mainboard.h b/src/mainboard/getac/p470/mainboard.h
index cc692f07a9..d340c7d3cd 100644
--- a/src/mainboard/getac/p470/mainboard.h
+++ b/src/mainboard/getac/p470/mainboard.h
@@ -3,6 +3,6 @@
struct acpi_rsdp;
-unsigned long mainboard_write_acpi_tables(struct device *device,
+unsigned long mainboard_write_acpi_tables(const struct device *device,
unsigned long start,
struct acpi_rsdp *rsdp);
diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c
index aa2de37c06..ba7ba655f0 100644
--- a/src/mainboard/google/dedede/mainboard.c
+++ b/src/mainboard/google/dedede/mainboard.c
@@ -26,7 +26,7 @@ static void mainboard_dev_init(struct device *dev)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
return current;
}
diff --git a/src/mainboard/google/eve/mainboard.c b/src/mainboard/google/eve/mainboard.c
index 76057b3a5d..ab7a5a8b28 100644
--- a/src/mainboard/google/eve/mainboard.c
+++ b/src/mainboard/google/eve/mainboard.c
@@ -21,7 +21,7 @@ static void mainboard_init(struct device *dev)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c
index 9f35411c24..4377af3f6c 100644
--- a/src/mainboard/google/fizz/mainboard.c
+++ b/src/mainboard/google/fizz/mainboard.c
@@ -187,7 +187,7 @@ static void mainboard_init(struct device *dev)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
const char *oem_id = NULL;
const char *oem_table_id = NULL;
diff --git a/src/mainboard/google/glados/mainboard.c b/src/mainboard/google/glados/mainboard.c
index 53f9f60098..0d6ba32d0c 100644
--- a/src/mainboard/google/glados/mainboard.c
+++ b/src/mainboard/google/glados/mainboard.c
@@ -38,7 +38,7 @@ static uint8_t max_codec_enable(void)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c
index 00ede2cf60..dd4d40de91 100644
--- a/src/mainboard/google/octopus/mainboard.c
+++ b/src/mainboard/google/octopus/mainboard.c
@@ -71,7 +71,7 @@ static void mainboard_init(void *chip_info)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/google/poppy/mainboard.c b/src/mainboard/google/poppy/mainboard.c
index dc50399b88..e24d6bcaea 100644
--- a/src/mainboard/google/poppy/mainboard.c
+++ b/src/mainboard/google/poppy/mainboard.c
@@ -16,7 +16,7 @@ static void mainboard_init(struct device *dev)
mainboard_ec_init();
}
-static unsigned long mainboard_write_acpi_tables(struct device *device,
+static unsigned long mainboard_write_acpi_tables(const struct device *device,
unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c
index b17bf90c2e..66cf9c1b68 100644
--- a/src/mainboard/google/reef/mainboard.c
+++ b/src/mainboard/google/reef/mainboard.c
@@ -95,7 +95,7 @@ void __weak variant_nhlt_oem_overrides(const char **oem_id,
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/intel/cannonlake_rvp/mainboard.c b/src/mainboard/intel/cannonlake_rvp/mainboard.c
index 1fb4997b5d..bde45b110c 100644
--- a/src/mainboard/intel/cannonlake_rvp/mainboard.c
+++ b/src/mainboard/intel/cannonlake_rvp/mainboard.c
@@ -19,7 +19,7 @@ static void mainboard_init(void *chip_info)
gpio_configure_pads(pads, num);
}
-static unsigned long mainboard_write_acpi_tables(struct device *device,
+static unsigned long mainboard_write_acpi_tables(const struct device *device,
unsigned long current,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/intel/coffeelake_rvp/mainboard.c b/src/mainboard/intel/coffeelake_rvp/mainboard.c
index 48dbeb48ce..1759bb95b7 100644
--- a/src/mainboard/intel/coffeelake_rvp/mainboard.c
+++ b/src/mainboard/intel/coffeelake_rvp/mainboard.c
@@ -18,7 +18,7 @@ static void mainboard_init(void *chip_info)
gpio_configure_pads(pads, num);
}
-static unsigned long mainboard_write_acpi_tables(struct device *device,
+static unsigned long mainboard_write_acpi_tables(const struct device *device,
unsigned long current,
acpi_rsdp_t *rsdp)
{
diff --git a/src/mainboard/intel/glkrvp/mainboard.c b/src/mainboard/intel/glkrvp/mainboard.c
index d8ba962d47..f6015a1b7d 100644
--- a/src/mainboard/intel/glkrvp/mainboard.c
+++ b/src/mainboard/intel/glkrvp/mainboard.c
@@ -30,7 +30,7 @@ static void mainboard_init(void *chip_info)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
diff --git a/src/mainboard/intel/kunimitsu/mainboard.c b/src/mainboard/intel/kunimitsu/mainboard.c
index b645f7cb3c..6166a33f78 100644
--- a/src/mainboard/intel/kunimitsu/mainboard.c
+++ b/src/mainboard/intel/kunimitsu/mainboard.c
@@ -26,7 +26,7 @@ static uint8_t select_audio_codec(void)
}
static unsigned long mainboard_write_acpi_tables(
- struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
+ const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;