summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorZheng Bao <fishbaozi@gmail.com>2022-01-21 10:59:04 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-01-24 15:50:30 +0000
commit0d7eaba0d6fe70c57d8d45cc480f6cd460682a4d (patch)
tree8d15ec482c60abc8b6ef5ad3bc481ea22b53c625 /src/mainboard
parent426ea9670f7d2176fe53f27e723d9db09cf1892a (diff)
mb/google/guybrush: Change DDI settings for guybrush variants
Like the variant function to change DXIO settings, add a similar weak function to modify the DDI settings. Currently we follow the old way. Later we will find out a better way to avoid using weak function. Change-Id: I9898d717bc3025ea1ddc3b0db41325083324ed57 Signed-off-by: Zheng Bao <fishbaozi@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61140 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Chris Wang <chris.wang@amd.corp-partner.google.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/guybrush/port_descriptors.c7
-rw-r--r--src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h1
2 files changed, 7 insertions, 1 deletions
diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c
index af06e7f3ed..158a802322 100644
--- a/src/mainboard/google/guybrush/port_descriptors.c
+++ b/src/mainboard/google/guybrush/port_descriptors.c
@@ -95,7 +95,7 @@ static fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = {
};
/* TODO: verify the DDI table, since this is mostly an educated guess right now */
-static const fsp_ddi_descriptor guybrush_czn_ddi_descriptors[] = {
+static fsp_ddi_descriptor guybrush_czn_ddi_descriptors[] = {
{ /* DDI0 - eDP */
.connector_type = DDI_EDP,
.aux_index = DDI_AUX1,
@@ -127,6 +127,10 @@ void __weak variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptor
{
}
+void __weak variant_update_ddi_descriptors(fsp_ddi_descriptor *ddi_descriptors)
+{
+}
+
void mainboard_get_dxio_ddi_descriptors(
const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num,
const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num)
@@ -143,6 +147,7 @@ void mainboard_get_dxio_ddi_descriptors(
guybrush_czn_dxio_descriptors[WWAN_NVME].gpio_group_id = GPIO_18;
variant_update_dxio_descriptors(guybrush_czn_dxio_descriptors);
+ variant_update_ddi_descriptors(guybrush_czn_ddi_descriptors);
*dxio_descs = guybrush_czn_dxio_descriptors;
*dxio_num = ARRAY_SIZE(guybrush_czn_dxio_descriptors);
diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h
index b50a5901b4..ec9dec8136 100644
--- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h
@@ -49,6 +49,7 @@ const struct soc_amd_gpio *variant_tpm_gpio_table(size_t *size);
bool variant_has_pcie_wwan(void);
void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors);
+void variant_update_ddi_descriptors(fsp_ddi_descriptor *ddi_descriptors);
enum dxio_port_id {
WLAN,