diff options
| author | Tim Crawford <tcrawford@system76.com> | 2022-08-19 13:18:24 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2022-11-24 17:51:54 +0000 |
| commit | 705ebbea04778cef3b51bc7a06b216fd73a193d2 (patch) | |
| tree | fbd06dbbad58a043a0a06497df3e9011a418c34a /src/mainboard/system76/tgl-u/variants | |
| parent | c9cb8ff8fbc107c45a7583241032a401baa217f5 (diff) | |
mb/system76: Reset Realtek codec before configuring
Perform a codec reset before configuring to avoid potential issues like
oryp5 had before 86f410479ca9 ("mb/system76/oryp5: Reset HDA before
configuring").
Inspecting proprietary firmware for multiple boards shows that this is
always done as well.
Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66918
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
Diffstat (limited to 'src/mainboard/system76/tgl-u/variants')
| -rw-r--r-- | src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c | 3 | ||||
| -rw-r--r-- | src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c | 3 | ||||
| -rw-r--r-- | src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c | 3 |
3 files changed, 6 insertions, 3 deletions
diff --git a/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c b/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c index dc5f72e5d8..53a47bdb47 100644 --- a/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x155851a1, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x155851a1), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), diff --git a/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c b/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c index 1f21ff77e7..c0afb196dc 100644 --- a/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x15584018, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x15584018), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), diff --git a/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c b/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c index 1259ba10ff..43a0ee5aed 100644 --- a/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x155814a1, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x155814a1), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), |