diff options
| author | Tim Crawford <tcrawford@system76.com> | 2022-07-24 17:09:16 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-08-02 15:51:16 +0000 |
| commit | 57fecef66f993a519105f6effb408d9caae1bcac (patch) | |
| tree | 1f1b3f6977df7869c8fbb9f4123aebbfc231b920 /src/mainboard/system76/addw1/variants | |
| parent | 125082091655feb99892f1af440f282213f3037f (diff) | |
mb/system76: Change touchpad detection method
Use the new "detect" method instead of "probed". Fixes an uncommon issue
where i2c-hid fails to initialize the device on Linux.
Tested on: gaze15, gaze16-3060, lemp10, oryp8
Tested:
- Linux: Touchpad works across 50 reboots
- Windows: Touchpad is still detected as an I2C HID device
- Windows: Extra I2C HID devices are not shown in Device Manager
Change-Id: I6a899c64a6d77b65a2ae57ab8df81cd84b568184
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66129
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Diffstat (limited to 'src/mainboard/system76/addw1/variants')
| -rw-r--r-- | src/mainboard/system76/addw1/variants/addw1/overridetree.cb | 2 | ||||
| -rw-r--r-- | src/mainboard/system76/addw1/variants/addw2/overridetree.cb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/system76/addw1/variants/addw1/overridetree.cb b/src/mainboard/system76/addw1/variants/addw1/overridetree.cb index b85706c93f..fa327fd1ad 100644 --- a/src/mainboard/system76/addw1/variants/addw1/overridetree.cb +++ b/src/mainboard/system76/addw1/variants/addw1/overridetree.cb @@ -12,7 +12,7 @@ chip soc/intel/cannonlake register "generic.hid" = ""SYNA1202"" register "generic.desc" = ""Synaptics Touchpad"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)" - register "generic.probed" = "1" + register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end diff --git a/src/mainboard/system76/addw1/variants/addw2/overridetree.cb b/src/mainboard/system76/addw1/variants/addw2/overridetree.cb index 4ef8b1ed41..40e2128db3 100644 --- a/src/mainboard/system76/addw1/variants/addw2/overridetree.cb +++ b/src/mainboard/system76/addw1/variants/addw2/overridetree.cb @@ -13,7 +13,7 @@ chip soc/intel/cannonlake register "generic.hid" = ""SYNA1202"" register "generic.desc" = ""Synaptics Touchpad"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A14_IRQ)" - register "generic.probed" = "1" + register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end |