diff options
author | Felix Singer <felixsinger@posteo.net> | 2024-01-18 07:22:34 +0100 |
---|---|---|
committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-19 08:00:31 +0000 |
commit | ce391cd4260012cbe59121f276f36f1a60f22056 (patch) | |
tree | 6de65b032fb60d11442f899256181a734ee2cfb9 /src/mainboard/purism/librem_cnl/variants | |
parent | 185ff285f6e1094328f32416c2ba40b4363e043c (diff) |
mb/purism/librem_cnl: Use chipset dt reference names
Use the references from the chipset devicetree as this makes the
comments superfluous.
Change-Id: I87cec9026bcb621ceb7eae51f65ae35bc31d584a
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80056
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathon Hall <jonathon.hall@puri.sm>
Diffstat (limited to 'src/mainboard/purism/librem_cnl/variants')
-rw-r--r-- | src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb | 20 | ||||
-rw-r--r-- | src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb | 12 |
2 files changed, 16 insertions, 16 deletions
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb index ef35ac099d..b3fd862b52 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/overridetree.cb @@ -24,7 +24,7 @@ chip soc/intel/cannonlake # Actual device tree device domain 0 on - device pci 02.0 on # Integrated Graphics Device + device ref igpu on register "gfx" = "GMA_DEFAULT_PANEL(0)" register "panel_cfg" = "{ .up_delay_ms = 200, @@ -35,7 +35,7 @@ chip soc/intel/cannonlake .backlight_off_delay_ms = 1, }" end - device pci 14.0 on # USB xHCI + device ref xhci on chip drivers/usb/acpi device usb 0.0 on chip drivers/usb/acpi @@ -131,8 +131,8 @@ chip soc/intel/cannonlake register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC2)" # Type-C left register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Card Reader end - device pci 14.1 off end # USB xDCI (OTG) - device pci 15.0 on # I2C #0 + device ref xdci off end + device ref i2c0 on chip drivers/i2c/hid register "generic.hid" = ""HTIX5288"" register "generic.name" = ""TPD0"" @@ -142,7 +142,7 @@ chip soc/intel/cannonlake device i2c 2c on end end end - device pci 17.0 on # SATA + device ref sata on register "satapwroptimize" = "1" register "SataSalpSupport" = "1" # Port 2 (M.2 / inner) @@ -152,7 +152,7 @@ chip soc/intel/cannonlake register "SataPortsEnable[2]" = "1" register "SataPortsDevSlp[2]" = "1" end - device pci 1c.6 on # PCI Express Port 7 -- x1 M.2/E 2230 (WLAN) + device ref pcie_rp7 on # x1 M.2/E 2230 (WLAN) register "PcieRpEnable[6]" = "1" register "PcieRpSlotImplemented[6]" = "1" register "PcieRpLtrEnable[6]" = "1" @@ -161,13 +161,13 @@ chip soc/intel/cannonlake register "PcieClkSrcClkReq[2]" = "2" smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230" "SlotDataBusWidth1X" end - device pci 1c.7 on # PCI Express Port 8 + device ref pcie_rp8 on device pci 00.0 on end # x1 (LAN) register "PcieRpEnable[7]" = "1" register "PcieClkSrcUsage[3]" = "7" register "PcieClkSrcClkReq[3]" = "3" end - device pci 1d.0 on # PCI Express Port 9 -- x4 M.2/M 2280 (NVMe) + device ref pcie_rp9 on # x4 M.2/M 2280 (NVMe) register "PcieRpEnable[8]" = "1" register "PcieRpSlotImplemented[8]" = "1" register "PcieRpLtrEnable[8]" = "1" @@ -175,7 +175,7 @@ chip soc/intel/cannonlake register "PcieClkSrcClkReq[0]" = "0" smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" end - device pci 1d.4 on # PCI Express Port 13 -- x4 M.2/M 2280 (NVMe) + device ref pcie_rp13 on # x4 M.2/M 2280 (NVMe) register "PcieRpEnable[12]" = "1" register "PcieRpSlotImplemented[12]" = "1" register "PcieRpLtrEnable[12]" = "1" @@ -183,7 +183,7 @@ chip soc/intel/cannonlake register "PcieClkSrcClkReq[1]" = "1" smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" end - device pci 1f.0 on # LPC Bridge + device ref lpc_espi on # LPC configuration from lspci -s 1f.0 -xxx # Address 0x88: Decode 0x68 - 0x6F (EC PM channel) register "gen1_dec" = "0x00040069" diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb index cab254a306..f9baef2bf4 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/overridetree.cb @@ -20,7 +20,7 @@ chip soc/intel/cannonlake # Actual device tree device domain 0 on - device pci 14.0 on # USB xHCI + device ref xhci on chip drivers/usb/acpi device usb 0.0 on chip drivers/usb/acpi @@ -123,12 +123,12 @@ chip soc/intel/cannonlake register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC2)" # Type-A rear lower register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC2)" # Type-A rear upper end - device pci 17.0 on # SATA + device ref sata on register "SataPortsEnable[0]" = "1" # 2.5" register "SataPortsEnable[2]" = "1" # m.2 register "satapwroptimize" = "1" end - device pci 1c.7 on # PCI Express Port 8 -- x1 M.2/E 2230 (WLAN) + device ref pcie_rp8 on # x1 M.2/E 2230 (WLAN) register "PcieRpSlotImplemented[7]" = "1" register "PcieRpEnable[7]" = "1" register "PcieRpLtrEnable[7]" = "1" @@ -136,13 +136,13 @@ chip soc/intel/cannonlake register "PcieClkSrcUsage[2]" = "0x80" smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230" "SlotDataBusWidth1X" end - device pci 1d.1 on # PCI Express Port 10 + device ref pcie_rp10 on device pci 00.0 on end # x1 (LAN) register "PcieRpEnable[9]" = "1" register "PcieClkSrcUsage[3]" = "9" register "PcieClkSrcClkReq[3]" = "3" end - device pci 1d.4 on # PCI Express Port 13 -- x4 M.2/M 2280 (NVMe) + device ref pcie_rp13 on # x4 M.2/M 2280 (NVMe) register "PcieRpSlotImplemented[12]" = "1" register "PcieRpEnable[12]" = "1" register "PcieRpLtrEnable[12]" = "1" @@ -150,7 +150,7 @@ chip soc/intel/cannonlake register "PcieClkSrcClkReq[1]" = "1" smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" end - device pci 1f.0 on # LPC Bridge + device ref lpc_espi on chip superio/ite/it8528e device pnp 2e.1 on # UART1 io 0x60 = 0x3F8 |