summaryrefslogtreecommitdiff
path: root/src/mainboard/prodrive/hermes/variants
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-12-17 11:51:36 +0100
committerHung-Te Lin <hungte@chromium.org>2020-12-24 08:17:05 +0000
commitf651022df366565871ca28bff644c049f46bcf0e (patch)
tree11ce9c00e118b5c1784427c897251083c93809cf /src/mainboard/prodrive/hermes/variants
parent707e03d8b90cf8a25520b7c5db4fa76d3a276f6a (diff)
mb/prodrive/hermes: Drop EEPROM address function parameters
Only one EEPROM is used to store the board settings, and its I2C address is constant. Thus, there's no need to pass its address as a parameter. In addition, reduce the scope of the `I2C_ADDR_EEPROM` definition, since using it outside of eeprom.c would bypass the API's abstraction layer. Change-Id: I958304e6ed6df05af923139d44ff4fd1de204738 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46565 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/mainboard/prodrive/hermes/variants')
-rw-r--r--src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
index bdfce8a278..95024b6ccd 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
@@ -2,8 +2,6 @@
#include <soc/ramstage.h>
-#define I2C_ADDR_EEPROM 0x57
-
#if ENV_ROMSTAGE
#define FSP_UPD_SIGNATURE FSPM_UPD_SIGNATURE
#define EEPROM_OFFSET_FSP_SIGNATURE 0
@@ -25,6 +23,5 @@ typedef struct {
size_t size;
} fsp_params;
-bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_offset,
- size_t size);
-int check_signature(u8 addr, const size_t offset, const uint64_t signature);
+bool read_write_config(void *blob, size_t read_offset, size_t write_offset, size_t size);
+int check_signature(const size_t offset, const uint64_t signature);