summaryrefslogtreecommitdiff
path: root/src/mainboard/ocp/deltalake
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-01-31 15:15:11 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-01 08:22:28 +0000
commit6e82ebff73d0a2a9d29248885b30384f1f550376 (patch)
treef19901e9a5228dd1cb2c8f9a40e0328feba331a0 /src/mainboard/ocp/deltalake
parent6724ba4f045cbbe2326463cbeaf59becfb01342e (diff)
mb/ocp/deltalake: Fill ECC type in romstage
Fill the ECC type in `struct memory_info` in romstage, and in SoC code. The SMBIOS override is unnecessary, and this is not mainboard-specific. Change-Id: I8370b3ee7d75914b895946b53923598adf87b522 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50179 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Johnny Lin <Johnny_Lin@wiwynn.com> Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-by: Jonathan Zhang <jonzhang@fb.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/ocp/deltalake')
-rw-r--r--src/mainboard/ocp/deltalake/ramstage.c25
1 files changed, 0 insertions, 25 deletions
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index dc70eb23b2..7c79949a6c 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -23,31 +23,6 @@
extern struct fru_info_str fru_strings;
static char slot_id_str[SLOT_ID_LEN];
-/* Override SMBIOS type 16 error correction type. */
-unsigned int smbios_memory_error_correction_type(struct memory_info *meminfo)
-{
- const struct SystemMemoryMapHob *hob;
-
- hob = get_system_memory_map();
- assert(hob != NULL);
-
- switch (hob->RasModesEnabled) {
- case CH_INDEPENDENT:
- return MEMORY_ARRAY_ECC_SINGLE_BIT;
- case FULL_MIRROR_1LM:
- case PARTIAL_MIRROR_1LM:
- case FULL_MIRROR_2LM:
- case PARTIAL_MIRROR_2LM:
- return MEMORY_ARRAY_ECC_MULTI_BIT;
- case RK_SPARE:
- return MEMORY_ARRAY_ECC_SINGLE_BIT;
- case CH_LOCKSTEP:
- return MEMORY_ARRAY_ECC_SINGLE_BIT;
- default:
- return MEMORY_ARRAY_ECC_MULTI_BIT;
- }
-}
-
/*
* Update SMBIOS type 0 ec version.
* In deltalake, BMC version is used to represent ec version.