diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-09-25 01:21:19 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-09-30 11:09:34 +0000 |
| commit | 16fe2eec083fa9465b157a322111cd6678a306d4 (patch) | |
| tree | 32d6fffd60652e88b07a469a3d8ec9acda804a54 /src/mainboard/lenovo/m900_tiny/Kconfig | |
| parent | 824071ae6765da4576a8cfdb3d9ae69b5bc84678 (diff) | |
drivers/i2c/at24rf08c: Disable DRIVER_LENOVO_SERIALS by default
This should be the sane default, as having this option enabled when the
AT24RF08C (Asset Identification EEPROM) is not present on the mainboard
can cause SMBIOS table entries to become "*INVALID*". This can,
for example, result in strange hostnames when an OS installer uses
SMBIOS information to automatically generate one. On the other hand,
the coreboot generated SMBIOS tables will at least always contain basic
information. Therefore, this driver should be treated as an enhancement
rather than a default.
Currently, the following mainboards have this option disabled:
- ThinkCentre M710s
- ThinkCentre M700 / M900 Tiny
- Haswell ThinkPads
- ThinkPad T440p
- ThinkPad W541
Therefore, we can remove this option entirely on these mainboards. Note
that there may be other mainboards which do not have this chip present
but still have the option enabled. However, this requires a more
detailed investigation which would be out of scope of this change.
TESTS=Timeless builds on lenovo mainboards produce the same binary.
config INCLUDE_CONFIG_FILE
default n
Was temporarily added to `mb/lenovo/Kconfig` during these tests, as
while the configuration does not change, the order of entries do.
Therefore, technically producing a different binary when included.
Change-Id: I5bb101bd6696c39718ee779426d0ec3e721e1b51
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84544
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/lenovo/m900_tiny/Kconfig')
| -rw-r--r-- | src/mainboard/lenovo/m900_tiny/Kconfig | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/lenovo/m900_tiny/Kconfig b/src/mainboard/lenovo/m900_tiny/Kconfig index ffcf05879c..8ad36e0014 100644 --- a/src/mainboard/lenovo/m900_tiny/Kconfig +++ b/src/mainboard/lenovo/m900_tiny/Kconfig @@ -2,6 +2,7 @@ if BOARD_LENOVO_THINKCENTRE_M900_TINY +# TODO: fix and enable DRIVER_LENOVO_SERIALS config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 @@ -37,8 +38,4 @@ config PRERAM_CBMEM_CONSOLE_SIZE config DIMM_SPD_SIZE default 512 #DDR4 -# TODO: fix and enable -config DRIVER_LENOVO_SERIALS - default n - endif |