diff options
| author | Keith Hui <buurin@gmail.com> | 2023-03-20 02:03:47 -0400 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-23 15:14:45 +0000 |
| commit | c5d6af43fb544423fa103f523ac85356b3ff3725 (patch) | |
| tree | 8cf30f87ba30b1e3334b4546dddd69dbd8b2ffdd /src/mainboard/intel | |
| parent | 0e1be046acaf5cfb9e2c41521270d137fa3423c5 (diff) | |
nb/intel/snb: Abolish mainboard_should_reset_usb()
Of the 13 mainboards that implement mainboard_should_reset_usb() hook,
all but one do the same: Stop MRC from resetting USB when resuming
from S3 suspend.
This hook turns out is only here to facilitate a USB reset workaround
on samsung/stumpy for an old ChromeOS kernel which is no longer needed.
Drop the workaround, the hook, and headers no longer used.
roda/rv11/early_init.c is left with no useful code after this patch,
so drop it entirely from both bootblock and romstage.
Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/intel')
| -rw-r--r-- | src/mainboard/intel/dcp847ske/romstage.c | 5 | ||||
| -rw-r--r-- | src/mainboard/intel/emeraldlake2/early_init.c | 5 |
2 files changed, 0 insertions, 10 deletions
diff --git a/src/mainboard/intel/dcp847ske/romstage.c b/src/mainboard/intel/dcp847ske/romstage.c index 0232486403..e7b936ae35 100644 --- a/src/mainboard/intel/dcp847ske/romstage.c +++ b/src/mainboard/intel/dcp847ske/romstage.c @@ -41,9 +41,4 @@ void mainboard_fill_pei_data(struct pei_data *pei_data) }; *pei_data = pei_data_template; } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} #endif diff --git a/src/mainboard/intel/emeraldlake2/early_init.c b/src/mainboard/intel/emeraldlake2/early_init.c index 11b3121b6c..c697ef2bf3 100644 --- a/src/mainboard/intel/emeraldlake2/early_init.c +++ b/src/mainboard/intel/emeraldlake2/early_init.c @@ -113,8 +113,3 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) read_spd(&spd[0], 0x50, id_only); read_spd(&spd[2], 0x52, id_only); } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} |