summaryrefslogtreecommitdiff
path: root/src/mainboard/intel/mtlrvp/variants
diff options
context:
space:
mode:
authorJamie Ryu <jamie.m.ryu@intel.com>2022-07-27 04:11:26 -0700
committerFelix Held <felix-coreboot@felixheld.de>2023-01-10 14:42:37 +0000
commit12367e0db1150cfb6c75af3e5a41a0e409f7a0c1 (patch)
treea3437be3d74e829bfaa471fa7baed54b7a9fd534 /src/mainboard/intel/mtlrvp/variants
parent21c3c44ef55d5ed3b69ea34fb2c8ee7541fde253 (diff)
mb/intel/mtlrvp: Add romstage and configure DDR5 memory parts
This patch adds initial romstage code and spd data for DDR5 memory parts for MTL-RVP. This also configures memory based on the board id. Memory - x32 DDR5 SBS SODIMM 1DPC Vendor/Model - SK-Hynix/HMCG66MEBSA092N BUG=b:224325352 TEST=Able to boot intel/mtlrvp (DDR5 SKU) to ChromeOS Signed-off-by: Jamie Ryu <jamie.m.ryu@intel.com> Change-Id: I0e1a26d99e170311a89412f44b7cbb0430788f58 Signed-off-by: Harsha B R <harsha.b.r@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66190 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Usha P <usha.p@intel.com> Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src/mainboard/intel/mtlrvp/variants')
-rw-r--r--src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h4
-rw-r--r--src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/Makefile.inc3
-rw-r--r--src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/memory.c38
3 files changed, 45 insertions, 0 deletions
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h b/src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h
index 562abdf33a..f755ff0238 100644
--- a/src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h
@@ -3,6 +3,7 @@
#ifndef __BASEBOARD_VARIANTS_H__
#define __BASEBOARD_VARIANTS_H__
+#include <soc/meminit.h>
#include <stdint.h>
enum mtl_boardid {
@@ -16,4 +17,7 @@ enum mtl_boardid {
void configure_early_gpio_pads(void);
void configure_gpio_pads(void);
+/* Function to initialize memory params based on variant */
+const struct mb_cfg *variant_memory_params(void);
+
#endif /*__BASEBOARD_VARIANTS_H__ */
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/Makefile.inc b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/Makefile.inc
new file mode 100644
index 0000000000..566f5cc767
--- /dev/null
+++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/Makefile.inc
@@ -0,0 +1,3 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+
+romstage-y += memory.c
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/memory.c b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/memory.c
new file mode 100644
index 0000000000..d4a53c8f26
--- /dev/null
+++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/memory/memory.c
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/variants.h>
+#include <console/console.h>
+#include <ec/intel/board_id.h>
+#include <soc/romstage.h>
+
+static const struct mb_cfg ddr5_mem_config = {
+ .type = MEM_TYPE_DDR5,
+
+ .rcomp = {
+ /* As per doc #729782, baseboard uses only 100 Ohm Rcomp resistor */
+ .resistor = 100,
+ },
+
+ .ect = true, /* Early Command Training */
+
+ .UserBd = BOARD_TYPE_ULT_ULX,
+
+ .LpDdrDqDqsReTraining = 1,
+
+ .ddr_config = {
+ .dq_pins_interleaved = false,
+ }
+};
+
+const struct mb_cfg *variant_memory_params(void)
+{
+ int board_id = get_rvp_board_id();
+
+ switch (board_id) {
+ case MTLP_DDR5_RVP:
+ return &ddr5_mem_config;
+ default:
+ die("Unknown board id = 0x%x\n", board_id);
+ break;
+ }
+}