diff options
| author | Cliff Huang <cliff.huang@intel.com> | 2023-09-29 00:12:51 -0700 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2023-10-03 08:29:36 +0000 |
| commit | c0d0aecf16bb827515bc719dc1d5ce0aa515287a (patch) | |
| tree | 3de2708618e3f048d5510a9fc865025779f47326 /src/mainboard/google | |
| parent | 3aa7bb0d3232dfcb0af0e18565a4ded83d70142d (diff) | |
mb/google/rex: Fix ISH I2C pad for suspend
During suspend, the ISH I2C transactions cannot go through
because the GPIO pads remain the pervious value.
The IO Standby State (IOSSTATE) needs to be changed to keep I2C bus
active and functional during suspend.
BUG=b:302612549
TEST=on Google/rex platform with ISH enabled, do suspend_stress_test
and check that no i2c failure.
Signed-off-by: Cliff Huang <cliff.huang@intel.com>
Change-Id: I9a2c902ed56461f3a535428db399c2050756f2da
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78179
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Li1 Feng <li1.feng@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/rex/variants/rex0/fw_config.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/rex/variants/rex0/fw_config.c b/src/mainboard/google/rex/variants/rex0/fw_config.c index 86cb78102e..cea55ec637 100644 --- a/src/mainboard/google/rex/variants/rex0/fw_config.c +++ b/src/mainboard/google/rex/variants/rex0/fw_config.c @@ -85,9 +85,9 @@ static const struct pad_config bt_i2s_disable_pads[] = { static const struct pad_config ish_enable_pads[] = { /* GPP_B02 : ISH I2C0_SDA */ - PAD_CFG_NF(GPP_B02, NONE, DEEP, NF3), + PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B02, NONE, DEEP, NF3), /* GPP_B03 : ISH_I2C0_SCL */ - PAD_CFG_NF(GPP_B03, NONE, DEEP, NF3), + PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B03, NONE, DEEP, NF3), /* GPP_D05 : ISH_UART_TX */ PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2), /* GPP_D06 : ISH_UART_RX */ |