summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-10-23 20:38:23 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-10-30 00:45:36 +0000
commit3cc2c38d50741fffb9193851a4a3b7c636f7cd4d (patch)
treed836bf1ee32e6132d9db9aa1f19c5779e3398ccc /src/mainboard/google
parent9f6cdbaaf5d1a799e314e0baf9f4fda218abdf75 (diff)
soc/intel/broadwell: Separate PCH in devicetree
Flesh out the PCH configuration into a separate chip. Keep it within the Broadwell SoC directory for now, to ease moving files around. The boards were prepared beforehand and the devicetrees require next to no changes. Tested on out-of-tree Acer Aspire E5-573, still boots. Change-Id: I28d948f3e6d85e669d12b29516d867c1d1ae9e1a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46700 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/auron/devicetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/auron_paine/overridetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/auron_yuna/overridetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/buddy/overridetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/gandof/overridetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/lulu/overridetree.cb4
-rw-r--r--src/mainboard/google/auron/variants/samus/overridetree.cb4
-rw-r--r--src/mainboard/google/jecht/devicetree.cb4
8 files changed, 16 insertions, 16 deletions
diff --git a/src/mainboard/google/auron/devicetree.cb b/src/mainboard/google/auron/devicetree.cb
index 09593b7b53..26a53366b4 100644
--- a/src/mainboard/google/auron/devicetree.cb
+++ b/src/mainboard/google/auron/devicetree.cb
@@ -26,7 +26,7 @@ chip soc/intel/broadwell
device pci 02.0 on end # vga controller
device pci 03.0 on end # mini-hd audio
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# EC range is 0x800-0x9ff
register "gen1_dec" = "0x00fc0801"
register "gen2_dec" = "0x00fc0901"
@@ -83,6 +83,6 @@ chip soc/intel/broadwell
device pci 1f.2 on end # SATA Controller
device pci 1f.3 off end # SMBus
device pci 1f.6 on end # Thermal
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/auron_paine/overridetree.cb b/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
index f5f3eeacdf..81110408c1 100644
--- a/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
+++ b/src/mainboard/google/auron/variants/auron_paine/overridetree.cb
@@ -8,12 +8,12 @@ chip soc/intel/broadwell
register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# DTLE DATA / EDGE values
register "sata_port0_gen3_dtle" = "0x5"
register "sata_port1_gen3_dtle" = "0x5"
device pci 1f.2 on end # SATA Controller
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb b/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
index 5a64648cd1..eb33d433e8 100644
--- a/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
+++ b/src/mainboard/google/auron/variants/auron_yuna/overridetree.cb
@@ -8,12 +8,12 @@ chip soc/intel/broadwell
register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# DTLE DATA / EDGE values
register "sata_port0_gen3_dtle" = "0x7"
register "sata_port1_gen3_dtle" = "0x5"
device pci 1f.2 on end # SATA Controller
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/buddy/overridetree.cb b/src/mainboard/google/auron/variants/buddy/overridetree.cb
index 5b6ab9f858..60fb08cbf7 100644
--- a/src/mainboard/google/auron/variants/buddy/overridetree.cb
+++ b/src/mainboard/google/auron/variants/buddy/overridetree.cb
@@ -10,7 +10,7 @@ chip soc/intel/broadwell
register "s0ix_enable" = "0"
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
register "sata_devslp_disable" = "0x1"
register "sio_i2c0_voltage" = "1" # 1.8V
@@ -36,6 +36,6 @@ chip soc/intel/broadwell
device pci 1c.3 on end # PCIe Port #4 - WLAN (becomes RP2)
device pci 1f.2 on end # SATA Controller
device pci 1f.3 on end # SMBus
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/gandof/overridetree.cb b/src/mainboard/google/auron/variants/gandof/overridetree.cb
index 924e7d3c90..c7e2421ee8 100644
--- a/src/mainboard/google/auron/variants/gandof/overridetree.cb
+++ b/src/mainboard/google/auron/variants/gandof/overridetree.cb
@@ -8,12 +8,12 @@ chip soc/intel/broadwell
register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# DTLE DATA / EDGE values
register "sata_port0_gen3_dtle" = "0x5"
register "sata_port1_gen3_dtle" = "0x5"
device pci 1f.2 on end # SATA Controller
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/lulu/overridetree.cb b/src/mainboard/google/auron/variants/lulu/overridetree.cb
index f5f3eeacdf..81110408c1 100644
--- a/src/mainboard/google/auron/variants/lulu/overridetree.cb
+++ b/src/mainboard/google/auron/variants/lulu/overridetree.cb
@@ -8,12 +8,12 @@ chip soc/intel/broadwell
register "gpu_panel_power_backlight_off_delay" = "2100" # 210ms
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# DTLE DATA / EDGE values
register "sata_port0_gen3_dtle" = "0x5"
register "sata_port1_gen3_dtle" = "0x5"
device pci 1f.2 on end # SATA Controller
-# end
+ end
end
end
diff --git a/src/mainboard/google/auron/variants/samus/overridetree.cb b/src/mainboard/google/auron/variants/samus/overridetree.cb
index 93445756e2..d8aec0ae04 100644
--- a/src/mainboard/google/auron/variants/samus/overridetree.cb
+++ b/src/mainboard/google/auron/variants/samus/overridetree.cb
@@ -17,7 +17,7 @@ chip soc/intel/broadwell
register "s0ix_enable" = "0"
device domain 0 on
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
register "sata_port0_gen3_tx" = "0x72"
# Set I2C0 to 1.8V
@@ -37,6 +37,6 @@ chip soc/intel/broadwell
device pci 1c.2 on end # PCIe Port #3
device pci 1d.0 off end # USB2 EHCI
device pci 1f.2 on end # SATA Controller
-# end
+ end
end
end
diff --git a/src/mainboard/google/jecht/devicetree.cb b/src/mainboard/google/jecht/devicetree.cb
index e5508228c9..94fd8044c1 100644
--- a/src/mainboard/google/jecht/devicetree.cb
+++ b/src/mainboard/google/jecht/devicetree.cb
@@ -18,7 +18,7 @@ chip soc/intel/broadwell
device pci 02.0 on end # vga controller
device pci 03.0 on end # mini-hd audio
-# chip soc/intel/broadwell/pch
+ chip soc/intel/broadwell/pch
# SuperIO range is 0x700-0x73f
register "gen2_dec" = "0x003c0701"
@@ -113,6 +113,6 @@ chip soc/intel/broadwell
device pci 1f.2 on end # SATA Controller
device pci 1f.3 on end # SMBus
device pci 1f.6 on end # Thermal
-# end
+ end
end
end