diff options
| author | Reka Norman <rekanorman@google.com> | 2021-09-22 11:01:32 +1000 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2021-09-23 06:52:04 +0000 |
| commit | 6c411e6a39e3ea8b35ab2a99c16b6afc6bb32140 (patch) | |
| tree | 59afc392faa28891890defbbb831bbdfd828e116 /src/mainboard/google/volteer/variants/halvor | |
| parent | 42b06e6b5cfe33eff7896bb20790fcc15cfa9a5c (diff) | |
mb/google: Bulk rename mem_list_variant.txt to mem_parts_used.txt
The variant creation script creates a placeholder file called
mem_parts_used.txt, with the intent that variant owners will populate
this file with memory parts as needed. But instead, some partners have
been adding the parts in a new file called mem_list_variant.txt and
removing the placeholder file. E.g. https://review.coreboot.org/55735.
There's nothing wrong with this, but it's confusing to have two
different file names which serve the same purpose. Bulk rename all the
mem_list_variant.txt files to mem_parts_used.txt. The only time these
file names are used is as an argument to the spd_tools part_id_gen
script, so no other changes are necessary.
BUG=None
TEST=Re-run part_id_gen for all variants of
brya/volteer/dedede/guybrush/zork. Check that the only change is to the
"Generated by" comment in Makefile.inc and dram_id.generated.txt.
Signed-off-by: Reka Norman <rekanorman@google.com>
Change-Id: Icdeee78ae5c01e97f66c759c127175b4962d5635
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57820
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/volteer/variants/halvor')
| -rw-r--r-- | src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/mainboard/google/volteer/variants/halvor/memory/dram_id.generated.txt | 2 | ||||
| -rw-r--r-- | src/mainboard/google/volteer/variants/halvor/memory/mem_parts_used.txt (renamed from src/mainboard/google/volteer/variants/halvor/memory/mem_list_variant.txt) | 0 |
3 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc b/src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc index 80bd7f57e9..b34a62d5fd 100644 --- a/src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen TGL lp4x src/mainboard/google/volteer/variants/halvor/memory src/mainboard/google/volteer/variants/halvor/memory/mem_list_variant.txt +# util/spd_tools/bin/part_id_gen TGL lp4x src/mainboard/google/volteer/variants/halvor/memory src/mainboard/google/volteer/variants/halvor/memory/mem_parts_used.txt SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 0(0b0000) Parts = H9HKNNNCRMBVAR-NEH diff --git a/src/mainboard/google/volteer/variants/halvor/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/halvor/memory/dram_id.generated.txt index d2bfdf921f..304623ae5f 100644 --- a/src/mainboard/google/volteer/variants/halvor/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/halvor/memory/dram_id.generated.txt @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen TGL lp4x src/mainboard/google/volteer/variants/halvor/memory src/mainboard/google/volteer/variants/halvor/memory/mem_list_variant.txt +# util/spd_tools/bin/part_id_gen TGL lp4x src/mainboard/google/volteer/variants/halvor/memory src/mainboard/google/volteer/variants/halvor/memory/mem_parts_used.txt DRAM Part Name ID to assign H9HKNNNCRMBVAR-NEH 0 (0000) diff --git a/src/mainboard/google/volteer/variants/halvor/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/halvor/memory/mem_parts_used.txt index 8fdcce6030..8fdcce6030 100644 --- a/src/mainboard/google/volteer/variants/halvor/memory/mem_list_variant.txt +++ b/src/mainboard/google/volteer/variants/halvor/memory/mem_parts_used.txt |