summaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer/variants/delbin/overridetree.cb
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2024-06-27 22:58:52 +0200
committerFelix Singer <felixsinger@posteo.net>2024-06-29 20:03:50 +0000
commitbc8f5405b542eef35a71e5189d71654cbe134558 (patch)
tree289b1339565fb614281b31e07f09bb933c1465b8 /src/mainboard/google/volteer/variants/delbin/overridetree.cb
parent0adf35537bd6093b79b1701becee823d3436d975 (diff)
tgl mainboards: Move usb{2,3}_ports settings into XHCI device scope
Change-Id: Ide5126c6e642ca16249efeaf46321724f2ddce9a Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83245 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/mainboard/google/volteer/variants/delbin/overridetree.cb')
-rw-r--r--src/mainboard/google/volteer/variants/delbin/overridetree.cb24
1 files changed, 14 insertions, 10 deletions
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
index cc970f7f1d..c4f915c12e 100644
--- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -51,16 +51,6 @@ chip soc/intel/tigerlake
},
},
}"
- #These settings improve the USB2 Port1 eye diagram
- register "usb2_ports[3]" = "{
- .enable = 1,
- .tx_bias = USB2_BIAS_28P15MV,
- .tx_emp_enable = USB2_PRE_EMP_ON,
- .pre_emp_bias = USB2_BIAS_56P3MV,
- .pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
- .type_c = 1,
- }"
- register "usb2_ports[8]" = "USB2_PORT_TYPE_C(OC_SKIP)"
register "tcc_offset" = "8"
@@ -255,6 +245,20 @@ chip soc/intel/tigerlake
end
end
device ref south_xhci on
+ register "usb2_ports" = "{
+ // These settings improve the USB2 Port4 eye diagram
+ [3] = {
+ .enable = 1,
+ .tx_bias = USB2_BIAS_28P15MV,
+ .tx_emp_enable = USB2_PRE_EMP_ON,
+ .pre_emp_bias = USB2_BIAS_56P3MV,
+ .pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
+ .type_c = 1,
+ },
+ [8] = USB2_PORT_TYPE_C(OC_SKIP),
+ }"
+
+
chip drivers/usb/acpi
device ref xhci_root_hub on
chip drivers/usb/acpi