summaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer/variants/baseboard
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2020-09-09 02:08:26 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-09-14 07:04:45 +0000
commit3b616e4bde7ac35a3a4babb2c4ac407c270024d9 (patch)
tree60c60ae8cded0604aa5bb7018414bc7c9bb14af1 /src/mainboard/google/volteer/variants/baseboard
parenta545d3083183fb3cab28306e35ec765c906c1a5b (diff)
mb/google/volteer: Fix GPP_E12 definition
GPP_E12 should not be defined in the baseboard as its use is determined by the variant. For legacy reasons, we still have GPP_E12 defined in early_gpio but should not. Malefor and volteer* have the same GPP_E12 definition, but that is a misconfiguration. I think that was a copy-paste that slipped through the reviews. BUG=b:157597158 TEST=volteer2 boots to the OS Change-Id: Ic3ef864827aa94b0b96e335565119f3d5d008837 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45197 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Diffstat (limited to 'src/mainboard/google/volteer/variants/baseboard')
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/gpio.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index c938b2845e..5d367e79de 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -422,9 +422,6 @@ static const struct pad_config early_gpio_table[] = {
/* C21 : UART2_TXD ==> H1_PCH_INT_ODL */
PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT),
- /* E12 : SPI1_MISO_IO1 ==> EN_PP3300_SSD */
- PAD_CFG_GPO(GPP_E12, 1, DEEP),
-
/* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
PAD_CFG_GPO(GPP_F11, 1, DEEP),
};