summaryrefslogtreecommitdiff
path: root/src/mainboard/google/skyrim
diff options
context:
space:
mode:
authorTim Van Patten <timvp@google.com>2023-07-31 12:17:43 -0600
committerMartin L Roth <gaumless@gmail.com>2023-08-04 20:48:11 +0000
commit71d60ce506941cec2965e609627759fce43f5fe9 (patch)
treead2f06903a7a03e217efabcd046d5619bf0bf77c /src/mainboard/google/skyrim
parentbd2c2520949aa53ea1323f22be5a3d9d9e05179c (diff)
mb/google/skyrim: Select ACPI_S1_NOT_SUPPORTED
As of OS/FW: 15276.0.0 - Skyrim is not able to wake from S1/standby. The wake issue either needs to be fixed, or S1 should not be advertised as a capability in the ACPI table. Select ACPI_S1_NOT_SUPPORTED to indicate that ACPI state S1 is not supported on Skyrim devices. This results in 'standby' being removed from /sys/power/state. BUG=b:263981434 TEST=suspend_stress_test TEST=frostflow-rev2 ~ # cat /sys/power/state freeze mem Change-Id: I85fcdca34187a8c275cf5a93beb931dfb27a7c87 Signed-off-by: Tim Van Patten <timvp@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76863 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Diffstat (limited to 'src/mainboard/google/skyrim')
-rw-r--r--src/mainboard/google/skyrim/Kconfig1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index 9b81502c7d..b18d24283e 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -11,6 +11,7 @@ config AMD_FWM_POSITION_INDEX
config BOARD_SPECIFIC_OPTIONS
def_bool y
+ select ACPI_S1_NOT_SUPPORTED
select AMD_SOC_CONSOLE_UART
select BOARD_ROMSIZE_KB_16384
select DISABLE_KEYBOARD_RESET_PIN