diff options
| author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-01-11 17:41:37 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2023-01-15 02:01:48 +0000 |
| commit | 4902e9b35f1b62c2c28e582e33ad55d2543f1483 (patch) | |
| tree | ecf83ae2983dbf3318bbb2bf315eee6cc3ed903d /src/mainboard/google/skyrim | |
| parent | 2e6c55946c4d4ff04e1bc8de7272a4cef63ed55d (diff) | |
drivers/i2c/generic: Drop 'disable_gpio_export_in_crs' flag
Exposing the GPIOs via an ACPI PowerResource and the _CRS results in the
OS driver and ACPI thinking they own the GPIO. This can cause timing
problems because it's not clear which system should be controlling the
GPIO.
Previously, we flagged as an error any device which set the
'has_power_resource' flag but did not set 'disable_gpio_export_in_crs.'
There's no reason to require explicit disablement however, so drop the
superfluous 'disable' flag, and change the _CRS generation to check if
the GPIOs will be exported via the 'has_power_resource' flag instead.
BUG=b:265055477
TEST=build/boot skyrim, dump SSDT and verify touchscreen GPIOs only
listed under PRx, not under _CRS.
Change-Id: I837ae6c6fe4b8e1c4e10686406cba06bdb7759d2
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71849
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Diffstat (limited to 'src/mainboard/google/skyrim')
| -rw-r--r-- | src/mainboard/google/skyrim/variants/skyrim/overridetree.cb | 1 | ||||
| -rw-r--r-- | src/mainboard/google/skyrim/variants/winterhold/overridetree.cb | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb index 3f7ad721c1..0b9781ecfe 100644 --- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb @@ -146,7 +146,6 @@ chip soc/amd/mendocino register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" register "stop_off_delay_ms" = "2" register "has_power_resource" = "1" - register "disable_gpio_export_in_crs" = "1" device i2c 10 on end end chip drivers/generic/gpio_keys diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index b4e7c467f5..71888c4b0d 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -230,7 +230,6 @@ chip soc/amd/mendocino register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" register "stop_off_delay_ms" = "2" register "has_power_resource" = "1" - register "disable_gpio_export_in_crs" = "1" device i2c 34 on end end chip drivers/generic/gpio_keys |