summaryrefslogtreecommitdiff
path: root/src/mainboard/google/reef/variants/pyro
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-12-20 16:31:51 -0600
committerMartin L Roth <gaumless@gmail.com>2022-12-22 20:37:33 +0000
commit48894ea6207f69f7a1b8e916a35baacb861065e0 (patch)
tree6afe63d1e87e265eb8829f9e0a01434c1c893255 /src/mainboard/google/reef/variants/pyro
parentbeb58a93cf52025db6c3c9eeedfa5531a67190e0 (diff)
mb/google/reef: Set touchpad/screen IRQs to LEVEL vs EDGE
The GPIOs themselves are configured as level triggered, and the drivers (both Linux and Windows) work better with LEVEL vs EDGE triggering. TEST=tested with rest of patch train Change-Id: I1000df10eea5670bf1bc8d04c736150b6a5e26a1 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71153 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/google/reef/variants/pyro')
-rw-r--r--src/mainboard/google/reef/variants/pyro/devicetree.cb4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb
index 3dfb96bf30..b4ff375d7b 100644
--- a/src/mainboard/google/reef/variants/pyro/devicetree.cb
+++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb
@@ -211,7 +211,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "reset_delay_ms" = "20"
@@ -225,7 +225,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "wake" = "GPE0_DW1_15"
register "detect" = "1"
device i2c 15 on end