summaryrefslogtreecommitdiff
path: root/src/mainboard/google/reef/variants/coral
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2020-11-10 14:57:10 -0700
committerTim Wawrzynczak <twawrzynczak@chromium.org>2020-11-13 01:29:13 +0000
commit3614270a7646191d17b2a2cc6009e3c0bb41d47a (patch)
tree5f4938cf6a8268af44010c1a70c6f7920dd08f3e /src/mainboard/google/reef/variants/coral
parentc37e1e6d071cc9c64e99cffa4250e912f70e6ef0 (diff)
mb/google/reef: Configure IRQs as level triggered for HID over I2C
As per HID over I2C Protocol Specification[1] Version 1.00 Section 7.4, the interrupt line used by the device is required to be level triggered. Hence, this change updates the configuration of the HID over I2C devices to be level triggered. References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d96d5b/hid-over-i2c-protocol-spec-v1-0.docx BUG=b:172846122 TEST=./util/abuild/abuild Change-Id: Ifc6dd5f6549e7501f350afe8456a9a8096edcc25 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47425 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/reef/variants/coral')
-rw-r--r--src/mainboard/google/reef/variants/coral/devicetree.cb2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb
index fd456ebb54..649293138d 100644
--- a/src/mainboard/google/reef/variants/coral/devicetree.cb
+++ b/src/mainboard/google/reef/variants/coral/devicetree.cb
@@ -220,7 +220,7 @@ chip soc/intel/apollolake
chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50""
register "generic.desc" = ""Synaptics Touchpad""
- register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)"
+ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "generic.wake" = "GPE0_DW1_15"
register "generic.probed" = "1"
register "hid_desc_reg_offset" = "0x20"