summaryrefslogtreecommitdiff
path: root/src/mainboard/google/octopus/variants/dood
diff options
context:
space:
mode:
authorEric Lai <ericr_lai@compal.corp-partner.google.com>2020-09-16 11:21:08 +0800
committerPatrick Georgi <pgeorgi@google.com>2020-09-21 12:41:57 +0000
commitfa0080d187c8086d28bcad7c33bac66f624aa753 (patch)
treeb59cfd878ef30b903fc98350869c7df6640b5ccf /src/mainboard/google/octopus/variants/dood
parent3da27ab681f1a754c553d325b20be32284a1b8d9 (diff)
mb/google/octopus: Clean up LTE power off function
All octopus board share the same power off sequence. Move to smihandler.c instead variant.c. BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB. Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com> Change-Id: I2be5a656fb42fff99c56d21aaa73ed9140caad37 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45436 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/octopus/variants/dood')
-rw-r--r--src/mainboard/google/octopus/variants/dood/variant.c31
1 files changed, 1 insertions, 30 deletions
diff --git a/src/mainboard/google/octopus/variants/dood/variant.c b/src/mainboard/google/octopus/variants/dood/variant.c
index dda24f8330..1a8a37164a 100644
--- a/src/mainboard/google/octopus/variants/dood/variant.c
+++ b/src/mainboard/google/octopus/variants/dood/variant.c
@@ -16,35 +16,6 @@ enum {
SKU_4_WIFI_2CAM = 4, /* Wifi + dual camera */
};
-struct gpio_with_delay {
- gpio_t gpio;
- unsigned int delay_msecs;
-};
-
-static void power_off_lte_module(u8 slp_typ)
-{
- const struct gpio_with_delay lte_power_off_gpios[] = {
- {
- GPIO_161, /* AVS_I2S1_MCLK -- PLT_RST_LTE_L */
- 30,
- },
- {
- GPIO_117, /* PCIE_WAKE1_B -- FULL_CARD_POWER_OFF */
- 100
- },
- {
- GPIO_67, /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
- 0
- }
- };
-
- for (int i = 0; i < ARRAY_SIZE(lte_power_off_gpios); i++) {
- gpio_output(lte_power_off_gpios[i].gpio, 0);
- mdelay(lte_power_off_gpios[i].delay_msecs);
- }
-}
-
-
void variant_smi_sleep(u8 slp_typ)
{
/* Currently use cases here all target to S5 therefore we do early return
@@ -55,7 +26,7 @@ void variant_smi_sleep(u8 slp_typ)
switch (google_chromeec_get_board_sku()) {
case SKU_1_LTE:
case SKU_3_LTE_2CAM:
- power_off_lte_module(slp_typ);
+ power_off_lte_module();
return;
default:
return;