diff options
| author | Nicholas Chin <nic.c3.14@gmail.com> | 2024-10-05 21:40:38 -0600 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-11-10 19:12:06 +0000 |
| commit | 93b4268fb794d334b913eb76a68e37597ad51caa (patch) | |
| tree | 126d8ac7963bd2191ccc229911bfa50d73f85cfe /src/mainboard/google/guybrush | |
| parent | 7b466fb60b7d3f7793baf419b8b67b4b324702f4 (diff) | |
mb/google/*: Explicitly include static.h for DEV_PTR
As per commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h
to static.h"), sources that require access to devicetree static devices
should directly include static.h. This allows static.h to be removed
from device.h, eliminating unnecessary dependencies on the devicetree
for objects that only need the device types and function declarations.
The DEV_PTR macro resolves to names declared in static_devices.h, which
is then included in static.h, so include the header whenever the macro
is used.
Change-Id: I05662e601af00866b7f26f4c6c6794b491bf676e
Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84678
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Jayvik Desai <jayvik@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/guybrush')
4 files changed, 4 insertions, 0 deletions
diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 49a80e7177..b803450d76 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -12,6 +12,7 @@ #include <device/device.h> #include <drivers/i2c/tpm/chip.h> #include <gpio.h> +#include <static.h> #include <variant/ec.h> #define BACKLIGHT_GPIO GPIO_129 diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c index a056a19832..8d09985b29 100644 --- a/src/mainboard/google/guybrush/port_descriptors.c +++ b/src/mainboard/google/guybrush/port_descriptors.c @@ -5,6 +5,7 @@ #include <device/pci_def.h> #include <gpio.h> #include <soc/platform_descriptors.h> +#include <static.h> #include <types.h> /* All PCIe Resets are handled in coreboot */ diff --git a/src/mainboard/google/guybrush/variants/guybrush/variant.c b/src/mainboard/google/guybrush/variants/guybrush/variant.c index 394270c7e2..ea39b66e84 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/variant.c +++ b/src/mainboard/google/guybrush/variants/guybrush/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <amdblocks/cpu.h> #include <gpio.h> +#include <static.h> bool variant_has_pcie_wwan(void) { diff --git a/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c b/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c index 247c132bf6..613b78ad65 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c @@ -6,6 +6,7 @@ #include <drivers/i2c/tpm/chip.h> #include <drivers/uart/acpi/chip.h> #include <gpio.h> +#include <static.h> static void cr50_devtree_update(void) { |