diff options
| author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2022-09-23 13:28:05 -0500 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-27 15:15:51 +0000 |
| commit | 2f4b31f5a00efd9b00933455df408d70ace6ff5f (patch) | |
| tree | 5029b7dac59f4124f444d11f2dfb9b43d005c0a9 /src/mainboard/google/guybrush/variants/baseboard | |
| parent | 4a16be91dd9bc3acee7af466a79a9fce857560e3 (diff) | |
mb/google/guybrush: rename baseboard GPIO table getter for clarity
Rename variant_base_gpio_table() to baseboard_gpio_table(), since the
GPIO table comes from the baseboard, and is overridden by a separate
table from the variant.
Drop the __weak qualifier as this function is not overridden.
Change-Id: Ib8439e664defeafd2d08cffb74c997ab69230231
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67806
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/google/guybrush/variants/baseboard')
| -rw-r--r-- | src/mainboard/google/guybrush/variants/baseboard/gpio.c | 2 | ||||
| -rw-r--r-- | src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h | 9 |
2 files changed, 3 insertions, 8 deletions
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index cfbabc1100..ccea5731f1 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -298,7 +298,7 @@ const struct soc_amd_gpio *__weak variant_bootblock_gpio_table(size_t *size) return bootblock_gpio_table; } -const struct soc_amd_gpio *__weak variant_base_gpio_table(size_t *size) +const struct soc_amd_gpio *baseboard_gpio_table(size_t *size) { *size = ARRAY_SIZE(base_gpio_table); return base_gpio_table; diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h index b2457d6cb0..bf694438bb 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h @@ -12,13 +12,8 @@ #define WWAN_DEVFN PCIE_GPP_2_2_DEVFN #define NVME_DEVFN PCIE_GPP_2_3_DEVFN -/* - * This function provides base GPIO configuration table. It is typically provided by - * baseboard using a weak implementation. If GPIO configuration for a variant differs - * significantly from the baseboard, then the variant can also provide a strong implementation - * of this function. - */ -const struct soc_amd_gpio *variant_base_gpio_table(size_t *size); +/* This function provides base GPIO configuration table. */ +const struct soc_amd_gpio *baseboard_gpio_table(size_t *size); /* * These functions allow variants to override any GPIOs that are different than the base GPIO * configuration provided without having to replace the entire file. |