aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/cyan/ramstage.c
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2017-10-03 15:39:22 -0500
committerMartin Roth <martinroth@google.com>2017-10-08 22:34:47 +0000
commitf2fc4972282bfa92be417bc6f3df3197c47ceb01 (patch)
tree76aa4d6eb924d19f7f10e14c303fc4b9b1f4eb25 /src/mainboard/google/cyan/ramstage.c
parent43ae4336b232100aa567cb7bd8a66de5f981fe3f (diff)
google/cyan: fix variant memory/silicon init params override
The mainboard_memory_init_params() and mainboard_silicon_init_params() methods already have weak definitions in drivers/intel/fsp1_1, so having them declared as weak in the cyan baseboard has the effect of them not being called at all unless overridden at the variant level. Therefore, remove the weak declarations in the baseboard and ensure that each variant has its own init functions if needed. TEST: build/boot google/cyan Change-Id: I1c76cb5838ef1e65e72c7341d951f9baf2ddd41b Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/21704 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/google/cyan/ramstage.c')
-rw-r--r--src/mainboard/google/cyan/ramstage.c21
1 files changed, 0 insertions, 21 deletions
diff --git a/src/mainboard/google/cyan/ramstage.c b/src/mainboard/google/cyan/ramstage.c
deleted file mode 100644
index 093a49bf16..0000000000
--- a/src/mainboard/google/cyan/ramstage.c
+++ /dev/null
@@ -1,21 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <soc/ramstage.h>
-
-__attribute__ ((weak))
-void mainboard_silicon_init_params(SILICON_INIT_UPD *params)
-{
-}