summaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya
diff options
context:
space:
mode:
authorJohn Su <john_su@compal.corp-partner.google.com>2022-03-07 15:34:54 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-03-09 14:29:44 +0000
commitfadd0ff40abf37c0b030820dfb850e1b4cc6e34b (patch)
tree4a1596bb4a5e52bf3e2f56cb42f71762fc154148 /src/mainboard/google/brya
parentc07d1bdc718c0e9d55f510e3f8162353d5cc7eb4 (diff)
mb/google/brya/variants/felwinter: Fix stylus UI behavior bug
Fix stylus UI behavior bug. 1) it appears the kernel's gpio_key driver is not expecting an IRQ descriptor for the `gpio` property, therefore change to an active-low input. 2) The wakeup event was configured backwards. Change list - Configure GPP_A7 as "ACPI_GPIO_INPUT_ACTIVE_LOW". - Change wakeup_event_action from ASSERTED to DEASSERTED. BUG=b:220992812 TEST=emerge-brya coreboot chromeos-bootimage and verify pass Signed-off-by: John Su <john_su@compal.corp-partner.google.com> Change-Id: I6f5e2992584d759eb1a559684d1cda08c7cbe3f2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62638 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/google/brya')
-rw-r--r--src/mainboard/google/brya/variants/felwinter/overridetree.cb4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index d1842764f3..acd96dd6b4 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -275,10 +275,10 @@ chip soc/intel/alderlake
end
chip drivers/generic/gpio_keys
register "name" = ""PENH""
- register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A7)"
+ register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_A7)"
register "key.wake_gpe" = "GPE0_DW0_08"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
- register "key.wakeup_event_action" = "EV_ACT_ASSERTED"
+ register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
register "key.dev_name" = ""EJCT""
register "key.linux_code" = "SW_PEN_INSERTED"
register "key.linux_input_type" = "EV_SW"