diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2022-01-06 08:35:56 -0700 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2022-01-12 03:56:14 +0000 |
| commit | a52b9c3a40dd082213b419f62d6ae3e1e071363b (patch) | |
| tree | 96ecf55c2913b66d85498dbe4b941d0c6f048e93 /src/mainboard/google/brya/variants/taeko4es/overridetree.cb | |
| parent | bf4592743c6b90c60a71842630e426a03b334e11 (diff) | |
mb/google/brya: Move gpio_pm settings for brya variants to baseboards
The factory versions (minor version 22) of cr50 FW have an issue with
producing short interrupt pulses, which can be missed by the ADL PCH
if autonomous GPIO power management is enabled, therefore instead of
continually adding the setting to all the variants, move it to the
baseboard instead.
Change-Id: I337f1e9e8f958c02bb73e6701a06c0b88a4757d7
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60872
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src/mainboard/google/brya/variants/taeko4es/overridetree.cb')
| -rw-r--r-- | src/mainboard/google/brya/variants/taeko4es/overridetree.cb | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb index 8aaeab7b71..5b7b49708e 100644 --- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb @@ -39,16 +39,6 @@ fw_config end end chip soc/intel/alderlake - # This disabled autonomous GPIO power management, otherwise - # old cr50 FW only supports short pulses; need to clarify - # the minimum PCH IRQ pulse width with Intel, b/180111628 - register "gpio_override_pm" = "1" - register "gpio_pm[COMM_0]" = "0" - register "gpio_pm[COMM_1]" = "0" - register "gpio_pm[COMM_2]" = "0" - register "gpio_pm[COMM_3]" = "0" - register "gpio_pm[COMM_4]" = "0" - register "gpio_pm[COMM_5]" = "0" register "ext_fivr_settings" = "{ .configure_ext_fivr = 1, .v1p05_enable_bitmap = FIVR_ENABLE_ALL_SX, |